Skip to content

fix: [10079] - Error state for NodeBalancer table cells - #12315

Merged
jaalah-akamai merged 11 commits into
linode:developfrom
hasyed-akamai:M3-10079-handle-error-state-for-nodebalancer-table-cells
Jun 11, 2025
Merged

fix: [10079] - Error state for NodeBalancer table cells#12315
jaalah-akamai merged 11 commits into
linode:developfrom
hasyed-akamai:M3-10079-handle-error-state-for-nodebalancer-table-cells

Conversation

@hasyed-akamai

@hasyed-akamai hasyed-akamai commented Jun 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Added error state for the NodeBalancer Table in VPC Details.
  • Aligned its header row with the Linode Table for consistency.

Changes

  • Implemented error state for the NodeBalancer Table under the Subnet table in VPC Details.
  • Updated table layout to match the Linode table header alignment.

Target Release Date

6/17

Preview

Before After
Before After
Before After

How to Test

  1. Add the required customer tags in Admin (as specified in the related ticket).
  2. Enable the VPC feature flag in Cloud Manager (CM) as noted in the ticket.
  3. Create a NodeBalancer associated with the VPC.
  4. Verify that the error state appears in the Backend Status and Firewall columns for the NodeBalancer row.
  5. Confirm that the NodeBalancer Table header is aligned with the Linode Table header.
Author Checklists

As an Author, I considered:

  • Self-review
  • Contribution guidelines
  • Small, focused PR
  • Changeset added if needed
  • Tests added or updated
  • No sensitive info
  • Feature flag if needed
  • Reproduction steps
  • Docs updated if needed
  • Mobile and a11y support

Before moving from Draft to Open:

  • All unit tests passing
  • TypeScript compiles
  • Linting passes

@hasyed-akamai hasyed-akamai self-assigned this Jun 3, 2025
@hasyed-akamai hasyed-akamai added the NB-VPC Relating to NodeBalancer-VPC integration label Jun 3, 2025
@hasyed-akamai
hasyed-akamai marked this pull request as ready for review June 4, 2025 07:13
@hasyed-akamai
hasyed-akamai requested a review from a team as a code owner June 4, 2025 07:13
@hasyed-akamai
hasyed-akamai requested review from dwiley-akamai and pmakode-akamai and removed request for a team June 4, 2025 07:13
dwiley-akamai
dwiley-akamai reviewed Jun 4, 2025
View reviewed changes
Comment thread packages/manager/src/features/VPCs/VPCDetail/SubnetNodebalancerRow.tsx Outdated
Comment thread packages/manager/src/features/VPCs/VPCDetail/SubnetNodebalancerRow.tsx Outdated
dwiley-akamai
dwiley-akamai approved these changes Jun 6, 2025
View reviewed changes

@dwiley-akamai dwiley-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small issue with status capitalization, but things LGTM otherwise ✅

Comment thread packages/manager/src/features/VPCs/VPCDetail/SubnetNodebalancerRow.tsx
@hasyed-akamai
hasyed-akamai force-pushed the M3-10079-handle-error-state-for-nodebalancer-table-cells branch from 6621bb6 to c504537 Compare June 9, 2025 06:36
pmakode-akamai
pmakode-akamai reviewed Jun 9, 2025
View reviewed changes

@pmakode-akamai pmakode-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️The unit test failures appear to be related to this PR. Could you take a look?

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Jun 10, 2025
pmakode-akamai
pmakode-akamai requested changes Jun 10, 2025
View reviewed changes
Comment thread packages/manager/src/features/VPCs/VPCDetail/VPCSubnetsTable.test.tsx Outdated
@github-project-automation github-project-automation Bot moved this from Approved to Changes Requested in Cloud Manager Jun 10, 2025
@linode-gh-bot

linode-gh-bot commented Jun 10, 2025

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 1 failing test on test run #13 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing660 Passing4 Skipped131m 28s

Details

Failing Tests
SpecTest
❌linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » linode storage tab

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts"

pmakode-akamai
pmakode-akamai approved these changes Jun 10, 2025
View reviewed changes

@pmakode-akamai pmakode-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the suggested changes! 👍

tests pass ✅

@github-project-automation github-project-automation Bot moved this from Changes Requested to Approved in Cloud Manager Jun 10, 2025
@pmakode-akamai pmakode-akamai added the Approved Multiple approvals and ready to merge! label Jun 10, 2025
@jaalah-akamai
jaalah-akamai merged commit 719874f into linode:develop Jun 11, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Jun 11, 2025
This was referenced Jun 12, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmakode-akamai pmakode-akamai pmakode-akamai approved these changes
@harsh-akamai harsh-akamai harsh-akamai approved these changes
+1 more reviewer
@dwiley-akamai dwiley-akamai dwiley-akamai approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@hasyed-akamai hasyed-akamai

Labels

Approved Multiple approvals and ready to merge! NB-VPC Relating to NodeBalancer-VPC integration 🚨 Urgent

Projects

Cloud Manager
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hasyed-akamai @linode-gh-bot @dwiley-akamai @pmakode-akamai @harsh-akamai @jaalah-akamai