Skip to content

upcoming: [M3-9882, M3-9879] - Update Upgrade Interfaces dialog height and Public IP addresses copy - #12332

Merged
coliu-akamai merged 6 commits into
linode:developfrom
coliu-akamai:m3-9882
Jun 6, 2025
Merged

upcoming: [M3-9882, M3-9879] - Update Upgrade Interfaces dialog height and Public IP addresses copy#12332
coliu-akamai merged 6 commits into
linode:developfrom
coliu-akamai:m3-9882

Conversation

@coliu-akamai

@coliu-akamai coliu-akamai commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Description 📝

  • Full height change: we're changing the Upgrade Interfaces dialog from a full height dialog to a min height dialog for desktop screen sizes (keeping full height for smaller sizes) after feedback
  • Public IP addresses copy - for Linode Interfaces, the tooltip used to say "not assigned to a network interface" even if its IP address was associated with an interface. Updated copy to be more specific in different cases
    • Note: working on this ticket has made me think of Linode Interface specific issues for the tooltip/copy - see M3-10105 for a follow up/stuff to clarify

Target release date 🗓️

before 6/30

Preview 📷

Before After
image image
image image

How to test 🧪

You'll need:

  • a Linode using legacy interfaces (to test upgrading)
  • a Linode using new interfaces - one interface - VPC interface only, no nat_1_1_address (no public IP address assigned)
  • a Linode using new interfaces - two interfaces - VPC interface, no nat_1_1_address (no public IP address assigned), with IPv4 set as the default route and a public interface

Verification steps

  • For the Linode using legacy interfaces, confirm the Upgrade Dialog height is no longer full height for md+ screensizes
  • For Linode with only a VPC interface - copy should still be the same as before (maybe some grammar changes)
  • For Linode with two interfaces - copy should match the 'after' picture

(adding a VLAN interface to the Linode Interfaces shouldn't change either copy)

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@coliu-akamai
coliu-akamai marked this pull request as ready for review June 4, 2025 20:37
@coliu-akamai
coliu-akamai requested a review from a team as a code owner June 4, 2025 20:37
@coliu-akamai
coliu-akamai requested review from bnussman-akamai, dwiley-akamai and pmakode-akamai and removed request for a team June 4, 2025 20:37

@bnussman-akamai bnussman-akamai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks for dialing this logic in 🔥

@dwiley-akamai dwiley-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialog height ✅
Public IP Addresses copy ✅
Code review ✅

Comment thread packages/manager/src/features/Linodes/PublicIPAddressesTooltip.tsx Outdated
@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Jun 5, 2025
@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Jun 5, 2025
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 653 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing653 Passing4 Skipped122m 11s

@coliu-akamai
coliu-akamai merged commit a1b8839 into linode:develop Jun 6, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Jun 6, 2025
@coliu-akamai
coliu-akamai deleted the m3-9882 branch June 6, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Linode Interfaces

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants