Skip to content

upcoming: [DI-25149] - Removing tags filter for linode flow #12335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikhagra-akamai merged 4 commits into from
Jun 6, 2025
Merged

upcoming: [DI-25149] - Removing tags filter for linode flow #12335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdbe212
upcoming: [DI-25149] - Removing tags filter for linode flow
santoshp210-akamai May 28, 2025
eca76a0
upcoming: [DI-25149] - Fixing linting
santoshp210-akamai Jun 5, 2025
dd6751d
upcoming: [DI-25149] - Add changeset
santoshp210-akamai Jun 5, 2025
d899921
Merge branch 'develop' into feature/remove-tags-filter
nikhagra-akamai Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-12335-upcoming-features-1749106731336.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Upcoming Features
---

Exclude tags column and filter from entity table for Linode-based Alerts in Cloudpulse Alerting ([#12335](https://github.com/linode/manager/pull/12335))
21 changes: 0 additions & 21 deletions ...ger/src/features/CloudPulse/Alerts/AlertsResources/AlertsResourcesFilterRenderer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,26 +52,5 @@ describe('AlertsResourcesFilterRenderer', () => {
);

expect(getByPlaceholderText('Select Regions')).toBeInTheDocument();

const tagProps = getAlertResourceFilterProps({
filterKey: 'tags',
handleFilterChange: handleFilterChangeMock,
handleFilteredRegionsChange: handleFilterChangeMock,
regionOptions: [],
tagOptions: ['tag1', 'tag2'],
});
const tagPropKeys = Object.keys(tagProps);
expect(tagPropKeys.includes('handleFilterChange')).toBeTruthy();
expect(tagPropKeys.includes('handleSelectionChange')).toBeFalsy();

// Check for region filter
renderWithTheme(
<AlertResourcesFilterRenderer
component={serviceToFiltersMap['linode'][1].component}
componentProps={tagProps}
/>
);

expect(getByPlaceholderText('Select Tags')).toBeInTheDocument();
});
});
18 changes: 1 addition & 17 deletions packages/manager/src/features/CloudPulse/Alerts/AlertsResources/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,8 @@
import React from 'react';

import { engineTypeMap } from '../constants';
import { AlertsEngineTypeFilter } from './AlertsEngineTypeFilter';
import { AlertsRegionFilter } from './AlertsRegionFilter';
import { AlertsTagFilter } from './AlertsTagsFilter';
import { TextWithExtraInfo } from './TextWithExtraInfo';

import type { AlertInstance } from './DisplayAlertResources';
import type { TextWithInfoProp } from './TextWithExtraInfo';
import type {
AlertAdditionalFilterKey,
ServiceColumns,
Expand Down Expand Up @@ -58,14 +53,6 @@ export const serviceTypeBasedColumns: ServiceColumns<AlertInstance> = {
label: 'Region',
sortingKey: 'region',
},
{
accessor: ({ tags }) =>
React.createElement<Required<TextWithInfoProp>>(TextWithExtraInfo, {
values: tags ?? [],
}),
label: 'Tags',
sortingKey: 'tags',
},
],
};

Expand All @@ -78,10 +65,7 @@ export const serviceToFiltersMap: Record<
{ component: AlertsEngineTypeFilter, filterKey: 'engineType' },
{ component: AlertsRegionFilter, filterKey: 'region' },
],
linode: [
{ component: AlertsRegionFilter, filterKey: 'region' },
{ component: AlertsTagFilter, filterKey: 'tags' },
],
linode: [{ component: AlertsRegionFilter, filterKey: 'region' }],
};
export const applicableAdditionalFilterKeys: AlertAdditionalFilterKey[] = [
'engineType', // Extendable in future for filter keys like 'tags', 'plan', etc.
Expand Down