upcoming: [DPS-33117] Delivery form - #12350
Merged
mikeZuber-akamai merged 4 commits intoJun 12, 2025
Merged
mikeZuber-akamai merged 4 commits into
mikeZuber-akamai merged 4 commits into
Conversation
mduda-akamai
force-pushed
the
feature/DPS-33117-add-delivery-form
branch
from
June 10, 2025 09:34
7616bbf to
707162b
Compare
mduda-akamai
marked this pull request as ready for review
June 10, 2025 09:45
mduda-akamai
requested review from
abailly-akamai and
cpathipa
and removed request for
a team
June 10, 2025 09:45
abailly-akamai
left a comment
abailly-akamai
left a comment
Contributor
There was a problem hiding this comment.
You also need an APIv4 changeset
Contributor
Author
What do you mean by that? I haven't made any changes in APIv4 yet. |
abailly-akamai
approved these changes
Jun 11, 2025
abailly-akamai
left a comment
abailly-akamai
left a comment
Contributor
There was a problem hiding this comment.
You will want a better placeholder on your select because it is unclear one can create a new destination:
| control={control} | ||
| name="destination_label" | ||
| render={({ field }) => ( | ||
| <Autocomplete |
Contributor
There was a problem hiding this comment.
Not required, but you could also simplify this implementation by using the @linode/ui Select component which has a creatable property, cause that's essentially what you are trying to re-create here. We have one instance here: https://github.com/linode/manager/blob/develop/packages/manager/src/features/Managed/Contacts/ContactsDrawer.tsx
cpathipa
approved these changes
Jun 11, 2025
Cloud Manager UI test results🔺 4 failing tests on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/linodes/resize-linode.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts" |
||||||||||||||||||||||||||
This was referenced Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
DataStream: Delivery form
Changes 🔄
Target release date 🗓️
July 2025
Preview 📷
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
➕ Adding a changeset
🧪 Providing/improving test coverage
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅