Skip to content

fix: [M3-10080] - Missing query invalidations - #12351

Merged
bnussman-akamai merged 3 commits into
linode:developfrom
bnussman-akamai:M3-10080-fix-incorrect-grants-after-linode-clone
Jun 9, 2025
Merged

fix: [M3-10080] - Missing query invalidations#12351
bnussman-akamai merged 3 commits into
linode:developfrom
bnussman-akamai:M3-10080-fix-incorrect-grants-after-linode-clone

Conversation

@bnussman-akamai

Copy link
Copy Markdown
Member

Description 📝

This PR adds two cache invalidations. See code comments for what they do / why they are needed

How to test 🧪

Linode Clone Grants Fix

  • Login as a restricted user that has access to some Linode
  • Clone that Linode as the restricted user
  • Verify that once Cloud Manager sends you to the newly created Linode's details page, you have the expected permissions to read/write the Linode. This should just work without the user needing to refresh the page

Support Ticket Fix

Note

This one is hard to test. I just so happen to have an "important" support ticket on my account that was causing a notification and noticed that this needed to be fixed

  • Somehow have an account with an important support ticket (one that triggers a notification)
  • Close the ticket by clicking "Close Ticket" on the support ticket detail page
  • Verify the notification goes away without needing to refresh the page
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai self-assigned this Jun 9, 2025
@bnussman-akamai
bnussman-akamai requested a review from a team as a code owner June 9, 2025 14:27
@bnussman-akamai
bnussman-akamai requested review from cpathipa and mjac0bs and removed request for a team June 9, 2025 14:27
@bnussman-akamai bnussman-akamai added the Bug Fixes for regressions or bugs label Jun 9, 2025
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 2 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing658 Passing5 Skipped128m 43s

Details

Failing Tests
SpecTest
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » linode storage tab
access-key.e2e.spec.tsCloud Manager Cypress Tests→object storage access key end-to-end tests » object storage access key end-to-end tests

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts"

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the invalidation for the closed linode. I'll take your word for it on the support ticket notification; it makes sense.

Thanks for finding and fixing!

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jun 9, 2025
@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Jun 9, 2025
@cpathipa cpathipa added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jun 9, 2025
@bnussman-akamai
bnussman-akamai merged commit 643dab0 into linode:develop Jun 9, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants