change: [M3-9529] - Akamai Design System: inputAdornments - #12387
Merged
hasyed-akamai merged 5 commits intoJun 23, 2025
Merged
Conversation
hasyed-akamai
marked this pull request as ready for review
June 16, 2025 16:02
hasyed-akamai
requested review from
bnussman-akamai and
coliu-akamai
and removed request for
a team
June 16, 2025 16:02
hasyed-akamai
force-pushed
the
M3-9529-ads-inputAdornments
branch
from
June 18, 2025 05:55
c816ccc to
94ad679
Compare
bnussman-akamai
approved these changes
Jun 18, 2025
bnussman-akamai
left a comment
bnussman-akamai
left a comment
Member
There was a problem hiding this comment.
Nice. Looks good!
I am seeing some differences between the spacing in the RegionSelect and ImageSelect. This might be okay and expected behavior, just wanted to note it in case it was related
coliu-akamai
approved these changes
Jun 18, 2025
coliu-akamai
left a comment
coliu-akamai
left a comment
Contributor
There was a problem hiding this comment.
thanks @hasyed-akamai! didn't see anything besides what Banks mentioned
would we also need a changeset in the manager package, or move the one in the UI package over?
coliu-akamai
added
Approved
…dornment and endAdornment props using InputAdornment
…dornment and endAdornment props using InputAdornment
hasyed-akamai
force-pushed
the
M3-9529-ads-inputAdornments
branch
from
June 22, 2025 07:14
569ce65 to
19b59c6
Compare
Cloud Manager UI test results🔺 2 failing tests on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts,cypress/e2e/core/linodes/resize-linode.spec.ts" |
||||||||||||||||||||
This was referenced Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Refactor
TextFieldandAutocompletecomponents to correctly useInputAdornmentfor adornments.Changes 🔄
TextFieldandAutocompletecomponents usingstartAdornmentorendAdornmentto wrap adornments withInputAdornment.Target release date 🗓️
N/A
How to test 🧪
InputAdornmentAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅