upcoming: [M3-10125] - Add feature flag support for Cloud NAT - #12388
Merged
hana-akamai merged 2 commits intoJun 17, 2025
Merged
hana-akamai merged 2 commits into
hana-akamai merged 2 commits into
Conversation
hana-akamai
requested review from
harsh-akamai and
pmakode-akamai
and removed request for
a team
June 16, 2025 16:25
bill-akamai
reviewed
Jun 16, 2025
Contributor
There was a problem hiding this comment.
Looks good @hana-akamai. Do we need a changeset?
✅ Verify Cloud NAT is present in the Dev Tools Feature Flags section
✅Verify Cloud NAT in the LD response
bill-akamai
approved these changes
Jun 16, 2025
Contributor
Author
|
@bill-akamai yes, thanks for catching! |
Cloud Manager UI test results🎉 659 passing tests on test run #2 ↗︎
|
pmakode-akamai
approved these changes
Jun 17, 2025
pmakode-akamai
added
Approved
This was referenced Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add feature flag support for Cloud NAT
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅