Skip to content

feat: [UIE-8819] - IAM RBAC: User Email validation - #12395

Merged
cpathipa merged 2 commits into
linode:developfrom
mpolotsk-akamai:UIE-8819-email-validation
Jun 23, 2025
Merged

cpathipa merged 2 commits into
linode:developfrom
mpolotsk-akamai:UIE-8819-email-validation

Conversation

@mpolotsk-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Updated email validation in the User Email Panel to match the backend's validation logic.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Added regex email validation to match backend.
  • Added a unit test.

Added a unit test to verify the validation displays the correct error message.

Target release date 🗓️

June 24th

How to test 🧪

Prerequisites

(How to setup test environment)

  • Ensure the Identity and Access Beta flag is enabled in dev tools
  • Use devenv and login as vagrant user

Verification steps

(How to verify changes)

  • Go to the “Email” section in the IAM User Details Tab.
  • Enter an invalid email like user#@example.com.
  • Click Save.
  • Ensure a validation message appears: Invalid email address.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai
mpolotsk-akamai force-pushed the UIE-8819-email-validation branch from 9fcd108 to a696fcd Compare June 17, 2025 13:43
@mpolotsk-akamai
mpolotsk-akamai marked this pull request as ready for review June 17, 2025 13:44
@mpolotsk-akamai
mpolotsk-akamai requested a review from a team as a code owner June 17, 2025 13:44
@mpolotsk-akamai
mpolotsk-akamai requested review from hana-akamai and harsh-akamai and removed request for a team June 17, 2025 13:44
@cpathipa
cpathipa removed the request for review from harsh-akamai June 17, 2025 13:48
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 3 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing661 Passing4 Skipped130m 36s

Details

Failing Tests
SpecTest
vpc-linodes-update.spec.tsCloud Manager Cypress Tests→VPC assign/unassign flows » VPC assign/unassign flows
vpc-create.spec.tsCloud Manager Cypress Tests→VPC create flow » VPC create flow
vpc-create.spec.tsCloud Manager Cypress Tests→VPC create flow » VPC create flow

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/vpc/vpc-linodes-update.spec.ts,cypress/e2e/core/vpc/vpc-create.spec.ts"

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Jun 23, 2025
@cpathipa
cpathipa requested a review from jaalah-akamai June 23, 2025 18:09
@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Jun 23, 2025
@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jun 23, 2025
@cpathipa
cpathipa merged commit 6bdf6c7 into linode:develop Jun 23, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants