Skip to content

refactor: [M3-10141] - Clean up getLinodeXFilter function #12452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hana-akamai merged 2 commits into from
Jul 2, 2025
Merged

refactor: [M3-10141] - Clean up getLinodeXFilter function #12452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6afb3d3
clean up getLinodeXFilter function
hana-akamai Jul 1, 2025
dab7ff8
Added changeset: Clean up getLinodeXFilter function
hana-akamai Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-12452-tech-stories-1751388936476.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tech Stories
---

Clean up getLinodeXFilter function ([#12452](https://github.com/linode/manager/pull/12452))
6 changes: 3 additions & 3 deletions packages/manager/src/features/Linodes/LinodeCreate/shared/LinodeSelectTable.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ describe('Linode Select Table', () => {
});

it('should filter out Linodes in distributed regions', () => {
const { filter } = getLinodeXFilter(undefined, '');
const { filter } = getLinodeXFilter('');

expect(filter).toHaveProperty('site_type', 'core');
});

it('should search for label, id, ipv4, tags', () => {
const { filter } = getLinodeXFilter(undefined, '12345678');
const { filter } = getLinodeXFilter('12345678');

expect(filter).toStrictEqual({
'+or': [
Expand All @@ -57,7 +57,7 @@ describe('Linode Select Table', () => {
});

it('should return an error if the x-filter is invalid', () => {
const { filterError } = getLinodeXFilter(undefined, '123 456');
const { filterError } = getLinodeXFilter('123 456');

expect(filterError).toHaveProperty(
'message',
Expand Down
8 changes: 1 addition & 7 deletions packages/manager/src/features/Linodes/LinodeCreate/shared/LinodeSelectTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,7 @@ export const LinodeSelectTable = (props: Props) => {
preferenceKey: 'linode-clone-select-table',
});

const { filter, filterError } = getLinodeXFilter(
preselectedLinodeId ? Number(preselectedLinodeId) : undefined,
query,
order,
orderBy
);
const { filter, filterError } = getLinodeXFilter(query, order, orderBy);

const { data, error, isFetching, isLoading } = useLinodesQuery(
{
Expand Down Expand Up @@ -253,7 +248,6 @@ export const LinodeSelectTable = (props: Props) => {
};

export const getLinodeXFilter = (
_preselectedLinodeId: number | undefined,
query: string,
order?: Order,
orderBy?: string
Expand Down