test: [M3-10076]- Add tests for ACLP alerts in Linode create flow - #12540
Merged
dmcintyr-akamai merged 56 commits intoJul 29, 2025
Conversation
…ithub.com:dmcintyr-akamai/manager into M3-10076_aclp_alerts
…ager into M3-10076_aclp_alerts
…ager into M3-10076_aclp_alerts
…ager into M3-10076_aclp_alerts
dmcintyr-akamai
marked this pull request as ready for review
July 22, 2025 14:37
dmcintyr-akamai
requested review from
bnussman-akamai,
jdamore-linode and
mjac0bs
and removed request for
a team
July 22, 2025 14:37
mjac0bs
changed the title
jaalah-akamai
approved these changes
Jul 29, 2025
jaalah-akamai
left a comment
jaalah-akamai
left a comment
Contributor
There was a problem hiding this comment.
cc: @pmakode-akamai
jaalah-akamai
added
e2e
Cloud Manager UI test results🔺 2 failing tests on test run #12 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/nodebalancers/nodebalancers-create-in-complex-form.spec.ts" |
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Replacement PR for #12394 bc the test setup changed significantly after i'd already rec'd approvals.
Test the UI and POST payload for linode creation when the region is and is not enabled for alerts. I've tried to implement tests for all the requirements in M3-10076. If i'm missing any, pls let me know. Test create flow for legacy and beta alerts, and that user can toggle between legacy and beta mode.
Changes 🔄
Tests added to new file at packages/manager/cypress/e2e/core/linodes/alerts-create.spec.ts.
For the first set of tests, the aclpBetaServices.linode.alerts feature flag is enabled. The create flow defaults to displaying the legacy alerts but these alerts are readonly. If the user switches to beta alerts, then the user can select the alerts from the alerts table, and the selected alerts are included in the POST payload.
The first and last test demonstrate that if a region that does not support alerts is selected, then it does not matter what the feature flag is, alerts will not be visible in the form.
I added 5 integration tests, and this is the purpose of each:
If a region is initially selected which does not support alerts, then alerts are not visible in the UI. If the user selects a new region w/ alerts enabled, then the alerts UI appears.
Alerts are readonly in the legacy form. Legacy alerts are NOT included code snippet displayed in the "View Codde Snippet" modal or in the POST payload.
Selected beta alerts are included in the code snippet and POST payload.
How to test 🧪
As an Author, before moving this PR from Draft to Open, I confirmed ✅