Skip to content

upcoming: [DI-26202] - Integrating Firewall service to Alerts - #12550

Merged
venkymano-akamai merged 4 commits into
linode:developfrom
santoshp210-akamai:feature/alert-firewall-ui-integration
Jul 23, 2025
Merged

upcoming: [DI-26202] - Integrating Firewall service to Alerts#12550
venkymano-akamai merged 4 commits into
linode:developfrom
santoshp210-akamai:feature/alert-firewall-ui-integration

Conversation

@santoshp210-akamai

@santoshp210-akamai santoshp210-akamai commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Description 📝

Integrate firewall service to Alerts

Changes 🔄

List any change(s) relevant to the reviewer.

  • Add firewall config for the AlertsResources
  • Add the relevant fetch instances API for firewalls
  • Add firewall in validation and types

Target release date 🗓️

23rd July

Preview 📷

firewall-alerts.mp4

How to test 🧪

Prerequisites

(How to setup test environment)

  • Use the alpha env (api.dev.linode.com) , mocks does not have the latest metric and dimension filter firewall service.
  • Under Monitor, click on Alerts Click on Create Alert
  • Since the API does not support alert creation for this service, creation is not yet possible . It will be tested once support from API is there.

Verification steps

(How to verify changes)

  • The proper firewall instances are being fetched to display in the entities table.
  • Evaluation Period, Polling Interval, Metrics and Dimensions and relevant options properly (relevant tofirewall) being fetched and rendered from the APIs.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@ankita-akamai

Copy link
Copy Markdown
Contributor

Add changeset!

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Jul 23, 2025
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 1 failing test on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing688 Passing5 Skipped125m 13s

Details

Failing Tests
SpecTest
access-key.e2e.spec.tsCloud Manager Cypress Tests→object storage access key end-to-end tests » object storage access key end-to-end tests

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts"

@venkymano-akamai

Copy link
Copy Markdown
Contributor

Merging since , cypress failures are not related to PR and all checks pass

@venkymano-akamai
venkymano-akamai merged commit de61bb5 into linode:develop Jul 23, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants