Skip to content

upcoming: [DPS-34044] - Validate streams and destinations - #12557

Merged
mikeZuber-akamai merged 1 commit into
linode:developfrom
kagora-akamai:feature/DPS-34044-validate-streams-and-destinations
Jul 31, 2025
Merged

upcoming: [DPS-34044] - Validate streams and destinations#12557
mikeZuber-akamai merged 1 commit into
linode:developfrom
kagora-akamai:feature/DPS-34044-validate-streams-and-destinations

Conversation

@kagora-akamai

@kagora-akamai kagora-akamai commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Description 📝

DataStream: Stream and Destination validation.

Changes 🔄

  • Stream form validation.
  • Destination form validation.
  • Create Stream request payload validation.

Target release date 🗓️

August 2025

Preview 📷

Before After
Screenshot 2025-07-23 at 12 36 17 Screenshot 2025-07-23 at 12 34 27
Screenshot 2025-07-23 at 13 14 50 Screenshot 2025-07-23 at 13 15 05

How to test 🧪

Prerequisites

  • Open Local Dev Tools
  • Enable MSW, set Base Preset to CRUD
  • Apply

Verification steps

Stream form:

  • Navigate to datastream/streams
  • Click on Create Stream button
  • Click on submit button (Create Stream) to see form fields being validated (fields also validate on blur)
  • Fill the name field and choose destination to see validation state change
  • Submit to create stream
    (creating stream with new destination is not yet supported, payload validation will throw error in console)

Destination form:

  • Navigate to datastream/destinations
  • Click on Create Destination button
  • Click on submit button (Create Destination) to see form fields being validated (fields also validate on blur)
    (Submitting the form is not yet implemented)
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
📱 Providing mobile support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@kagora-akamai kagora-akamai self-assigned this Jul 23, 2025
@kagora-akamai
kagora-akamai force-pushed the feature/DPS-34044-validate-streams-and-destinations branch from d90cdee to 2133b1f Compare July 24, 2025 06:57
@kagora-akamai
kagora-akamai marked this pull request as ready for review July 24, 2025 06:58
@kagora-akamai
kagora-akamai requested a review from a team as a code owner July 24, 2025 06:58
@kagora-akamai
kagora-akamai requested review from bnussman-akamai, hasyed-akamai, mduda-akamai, mikeZuber-akamai and skrol-akamai and removed request for a team July 24, 2025 06:58
@kagora-akamai
kagora-akamai force-pushed the feature/DPS-34044-validate-streams-and-destinations branch from 2133b1f to 228bbe4 Compare July 25, 2025 09:26
@kagora-akamai
kagora-akamai force-pushed the feature/DPS-34044-validate-streams-and-destinations branch from 228bbe4 to 73eb6e8 Compare July 28, 2025 09:56
@kagora-akamai
kagora-akamai force-pushed the feature/DPS-34044-validate-streams-and-destinations branch from 73eb6e8 to 6a72677 Compare July 30, 2025 13:15
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 3 failing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing698 Passing4 Skipped130m 36s

Details

Failing Tests
SpecTest
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts"

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Jul 31, 2025
@mikeZuber-akamai
mikeZuber-akamai merged commit 8954c18 into linode:develop Jul 31, 2025
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants