fix: [M3-10399] - Restore the previous date value when Cancel is clicked - #12611
Merged
Merged
Conversation
cpathipa
requested review from
bill-akamai and
bnussman-akamai
and removed request for
a team
July 30, 2025 20:34
Cloud Manager UI test results🎉 701 passing tests on test run #4 ↗︎
|
bnussman-akamai
approved these changes
Jul 31, 2025
bnussman-akamai
left a comment
bnussman-akamai
left a comment
Member
There was a problem hiding this comment.
Change looks reasonable!
We do have a usePrevious helper hook available if that would be useful
bill-akamai
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR fixes that when a user opens the DateTimeRangePicker and makes changes to the selected date or time, and then clicks the Cancel button, all changes are discarded and the fields revert to their previous values. This improves the user experience by allowing safe exploration without committing accidental changes.
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
8/12
Preview 📷
Datev201.mov
How to test 🧪
(How to verify changes)
Ensure the popover with calendar and time inputs appears.
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅