Skip to content

fix: Region Select change that is causing test failures - #12622

Merged
bnussman-akamai merged 1 commit into
linode:developfrom
bnussman-akamai:fix/region-select-highlight-behavior
Jul 31, 2025
Merged

fix: Region Select change that is causing test failures #12622
bnussman-akamai merged 1 commit into
linode:developfrom
bnussman-akamai:fix/region-select-highlight-behavior

Conversation

@bnussman-akamai

@bnussman-akamai bnussman-akamai commented Jul 31, 2025

Copy link
Copy Markdown
Member

Description 📝

How to test 🧪

  • Verify Cypress tests pass ✅

@bnussman-akamai bnussman-akamai self-assigned this Jul 31, 2025
@bnussman-akamai
bnussman-akamai requested a review from a team as a code owner July 31, 2025 21:39
@bnussman-akamai
bnussman-akamai requested review from cpathipa and mjac0bs and removed request for a team July 31, 2025 21:39

@jdamore-linode jdamore-linode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @bnussman-akamai! I see some of the impacted tests passing now 🚀

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming CI finishes doing its thing and continues to look good - should since tests are over halfway through and passing.

Do you know what about that change caused tests to break?

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Jul 31, 2025
@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Jul 31, 2025
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 1 failing test on test run #1 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing700 Passing4 Skipped133m 23s

Details

Failing Tests
SpecTest
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » linode storage tab

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts"

@bnussman-akamai

Copy link
Copy Markdown
Member Author

@mjac0bs From Joe:

The issue seems to be that typing a region name in the autocomplete and hitting "enter" doesn't work anymore -- before, the top(?) search result would have focus so the "enter" would select the region, but now it doesn't seem like the top result gets focus automaticall

@bnussman-akamai
bnussman-akamai merged commit bdce3d7 into linode:develop Jul 31, 2025
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! 🚨 Urgent

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants