Skip to content

fix: [M3-10364] - MSW CRUD: Using custom profile preset with restricted account leads to type error - #12650

Closed
coliu-akamai wants to merge 12 commits into
linode:developfrom
coliu-akamai:m3-10364
Closed

fix: [M3-10364] - MSW CRUD: Using custom profile preset with restricted account leads to type error#12650
coliu-akamai wants to merge 12 commits into
linode:developfrom
coliu-akamai:m3-10364

Conversation

@coliu-akamai

@coliu-akamai coliu-akamai commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Description 📝

  • Fixes the page crash when using the profile presets for MSW CRUD as a restricted user. The issue was caused by the grants endpoint returning undefined - we check grants at GoTo, line 22
  • Also adds custom grants preset

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

n/a

Preview 📷

image image

How to test 🧪

Prerequisites

  • Use MSW crud and custom profile preset. In the profile dialog, make your user restricted (see ticket for imgs/videos)

Reproduction steps

  • Something went wrong dialog appears

Verification steps

  • No error appears - you can use MSW as expected
  • Test out the new custom grants preset too - confirm changes made to your grants get saved and reflected in the MSW (example: change global add_firewalls preset to false, confirm Create Firewalls button gets disabled)
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@coliu-akamai coliu-akamai self-assigned this Aug 6, 2025
@coliu-akamai
coliu-akamai marked this pull request as ready for review August 7, 2025 15:51
@coliu-akamai
coliu-akamai requested a review from a team as a code owner August 7, 2025 15:51
@coliu-akamai
coliu-akamai requested review from hana-akamai and hasyed-akamai and removed request for a team August 7, 2025 15:51
@coliu-akamai
coliu-akamai marked this pull request as draft August 15, 2025 19:51
@coliu-akamai

coliu-akamai commented Aug 15, 2025

Copy link
Copy Markdown
Contributor Author

suddenly seeing the error again (after some rebases) but in a different format...re investigating
image

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 730 passing tests on test run #12 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing730 Passing4 Skipped123m 48s

@coliu-akamai

Copy link
Copy Markdown
Contributor Author

trying to work on another version to fix this new bug - closing this PR for now (may reopen later dependingon how the other one goes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants