change: [UIE-8835] - Permissions for billing payment methods - #12654
Merged
Conversation
abailly-akamai
force-pushed
the
UIE-8835
branch
from
August 8, 2025 07:36
4a0b5f5 to
0204af3
Compare
abailly-akamai
marked this pull request as ready for review
August 8, 2025 08:30
abailly-akamai
requested review from
aaleksee-akamai,
bnussman-akamai,
mpolotsk-akamai and
pmakode-akamai
and removed request for
a team
August 8, 2025 08:30
Cloud Manager UI test results🔺 2 failing tests on test run #8 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/account/restricted-user-details-pages.spec.ts" |
||||||||||||||||||||
bnussman-akamai
approved these changes
Aug 11, 2025
kwojtowiakamai
approved these changes
Aug 12, 2025
There was a problem hiding this comment.
✅ The buttons in the billing payment methods are correctly enabled/disabled based on the permissions/grants for the IAM and non-IAM users.
The billing payment methods are not displayed when the user has the account_viewer role (with list_payment_methods permission), but it was reported as a separate ticket 👉 UIE-9084
pmakode-akamai
approved these changes
Aug 12, 2025
aaleksee-akamai
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR implements (and fix existing) payments methods IAM permissions.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
August 26
Preview 📷
How to test 🧪
Prerequisites
Verification steps
set_default_payment_method,delete_payment_methodandcreate_payment_methodpermissions with either IAM permissions or MSW and ensure UI disabled corresponding actionsAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅