Skip to content

change: [UIE-8835] - Permissions for billing payment methods - #12654

Merged
abailly-akamai merged 7 commits into
linode:developfrom
abailly-akamai:UIE-8835
Aug 12, 2025
Merged

change: [UIE-8835] - Permissions for billing payment methods#12654
abailly-akamai merged 7 commits into
linode:developfrom
abailly-akamai:UIE-8835

Conversation

@abailly-akamai

@abailly-akamai abailly-akamai commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Description 📝

This PR implements (and fix existing) payments methods IAM permissions.

Changes 🔄

  • More granular permissions for components related to payment methods CRUD actions
  • Adapt tests

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

August 26

Preview 📷

Screenshot 2025-08-08 at 10 22 17

Screenshot 2025-08-08 at 10 24 15

Screenshot 2025-08-08 at 10 25 18

How to test 🧪

Prerequisites

  • MSW or iam (restricted) + regular account to compare

Verification steps

  • toggle set_default_payment_method, delete_payment_method and create_payment_method permissions with either IAM permissions or MSW and ensure UI disabled corresponding actions
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai changed the title [UIE-8835] change: [UIE-8835] - Permissions for billing payment methos Aug 8, 2025
@abailly-akamai abailly-akamai changed the title change: [UIE-8835] - Permissions for billing payment methos change: [UIE-8835] - Permissions for billing payment methods Aug 8, 2025
@abailly-akamai
abailly-akamai marked this pull request as ready for review August 8, 2025 08:30
@abailly-akamai
abailly-akamai requested a review from a team as a code owner August 8, 2025 08:30
@abailly-akamai
abailly-akamai requested review from aaleksee-akamai, bnussman-akamai, mpolotsk-akamai and pmakode-akamai and removed request for a team August 8, 2025 08:30
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 2 failing tests on test run #8 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing703 Passing4 Skipped132m 7s

Details

Failing Tests
SpecTest
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » delete disk
restricted-user-details-pages.spec.tsCloud Manager Cypress Tests→restricted user details pages » should disable action elements and buttons in the 'Linodes' details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/account/restricted-user-details-pages.spec.ts"

@kwojtowiakamai kwojtowiakamai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The buttons in the billing payment methods are correctly enabled/disabled based on the permissions/grants for the IAM and non-IAM users.

The billing payment methods are not displayed when the user has the account_viewer role (with list_payment_methods permission), but it was reported as a separate ticket 👉 UIE-9084

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Aug 12, 2025
@abailly-akamai
abailly-akamai merged commit 63f22d9 into linode:develop Aug 12, 2025
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants