Skip to content

upcoming: [M3-10416] - Redirect /account/quotas → /quotas when feature flag is enabled - #12693

Merged
cpathipa merged 53 commits into
linode:developfrom
cpathipa:M3-10416
Aug 14, 2025
Merged

cpathipa merged 53 commits into
linode:developfrom
cpathipa:M3-10416

Conversation

@cpathipa

@cpathipa cpathipa commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Description 📝

This PR updates the account/quotas page to redirect users to the new /quotas route when the iamRbacPrimaryNavChanges feature flag is enabled.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Added new /quotas route with conditional redirect to '/account/quotas'
  • Added conditional redirect to '/quotas' in the account route.
  • Updated cypress tests by disabling the mock flag.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

8/26

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Before After
image image

How to test 🧪

Verification steps

(How to verify changes)

  • Checkout the branch and run the app in local.
  • Enable the iamRbacPrimaryNavChanges flag → navigating to /account/quotas should redirect to /quotas.
  • Verify all the links and sublinks in the quotas page.
  • Disable the flag → /account/quotas should show the legacy quotas page (/account/quotas).
  • Confirm that back/forward navigation works without loops.
  • Verify no regression in legacy (account/quotas) billing page when flag is off.
  • Verify all the functionality and links in the new route /quotas.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

cpathipa and others added 30 commits August 4, 2025 16:19
…094060.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
…037270.md

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
@cpathipa
cpathipa removed the request for review from a team August 13, 2025 20:42
@cpathipa
cpathipa marked this pull request as draft August 13, 2025 20:43
@cpathipa cpathipa self-assigned this Aug 13, 2025
@cpathipa
cpathipa marked this pull request as ready for review August 14, 2025 14:52

@bill-akamai bill-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a failing test:

src/components/PrimaryNav/PrimaryNav.test.tsx > PrimaryNav > should show Administration links if iamRbacPrimaryNavChanges flag is enabled
TestingLibraryElementError: Unable to find role="link" and name "Quotas"

@github-project-automation github-project-automation Bot moved this from Review to Changes Requested in Cloud Manager Aug 14, 2025
@cpathipa

Copy link
Copy Markdown
Contributor Author

Thank you @bill-akamai Fixed the broken unit test 4dd8c4d

@cpathipa
cpathipa requested a review from bill-akamai August 14, 2025 16:05
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing717 Passing4 Skipped135m 45s

Details

Failing Tests
SpecTest
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » delete disk

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts"

@bill-akamai bill-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified steps as instructed ✅

@cpathipa cpathipa added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 14, 2025

@coliu-akamai coliu-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed steps

thanks @cpathipa!

@github-project-automation github-project-automation Bot moved this from Changes Requested to Approved in Cloud Manager Aug 14, 2025
@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 14, 2025
@cpathipa
cpathipa merged commit 346aa3b into linode:develop Aug 14, 2025
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants