fix: [DI-26675] - Alerts List cache bug fix for Edit Alert use-case - #12699
Merged
jaalah-akamai merged 5 commits intoAug 18, 2025
Merged
Conversation
santoshp210-akamai
requested review from
cpathipa and
dwiley-akamai
and removed request for
a team
August 14, 2025 14:49
bnussman-akamai
approved these changes
Aug 14, 2025
dwiley-akamai
approved these changes
Aug 14, 2025
cpathipa
approved these changes
Aug 15, 2025
Comment on lines
+112
to
+117
| if (oldAlerts) { | ||
| queryClient.setQueryData<Alert[]>( | ||
| allAlertsQueryKey, | ||
| oldAlerts.map((alert) => (alert.id === data.id ? data : alert)) | ||
| ); | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we use single setQueryData here ?
example:
queryClient.setQueryData<Alert[] | undefined>(allAlertsKey, (prev) => {
// nothing cached yet
if (!prev) return prev;
const idx = prev.findIndex((a) => a.id === data.id);
if (idx === -1) return prev;
// if no change keep referential equality
if (prev[idx] === data) return prev;
const next = prev.slice();
next[idx] = data;
return next;
});
Member
There was a problem hiding this comment.
Agreed. Using setQueryData with an "updater" function is preferred over getQueryData + setQueryData
Contributor
Author
There was a problem hiding this comment.
Will test this once and push the changes.
Contributor
Author
There was a problem hiding this comment.
@cpathipa , @bnussman-akamai I have tested this change, will go ahead and push this code change.
| "@linode/manager": Changed | ||
| --- | ||
|
|
||
| ACLP-Alerting: Conditionally setting the query data on sucessful edit alert operation ([#12699](https://github.com/linode/manager/pull/12699)) |
Contributor
There was a problem hiding this comment.
Suggested change
| ACLP-Alerting: Conditionally setting the query data on sucessful edit alert operation ([#12699](https://github.com/linode/manager/pull/12699)) | |
| ACLP-Alerting: Conditionally set the query data on successful edit alert operation ([#12699](https://github.com/linode/manager/pull/12699)) |
Cloud Manager UI test results🎉 724 passing tests on test run #5 ↗︎
|
This was referenced Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Conditionally setting the alert data for successful edit-alert
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
26th August
Preview 📷
edit-alert-list-cache-before.mp4
edit-alert-list-cache-after.mp4
How to test 🧪
Prerequisites
-Choose an Alert (either enabled or disabled) and click on the Action menu and choose Edit.
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅