Skip to content

fix: [M3-9034] - Use empty string instead of unknown for delete dialog titles - #12701

Merged
hana-akamai merged 5 commits into
linode:developfrom
hana-akamai:M3-9034-delete-domain-dialog
Aug 15, 2025
Merged

hana-akamai merged 5 commits into
linode:developfrom
hana-akamai:M3-9034-delete-domain-dialog

Conversation

@hana-akamai

@hana-akamai hana-akamai commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

Description 📝

Use empty string instead of unknown for delete dialog titles

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
before.mov
after.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • Have some Domains created

Reproduction steps

(How to reproduce the issue, if applicable)

  • On another branch, go to the Domains landing page
  • Open the network tab, disable cache, and throttle to the slowest speed you can
  • Open the delete dialog for a domain and while it is still fetching, hover over the close icon
  • The text tooltip displays unknown

Verification steps

(How to verify changes)

  • Checkout this PR and go to the Domains landing page
  • Open the network tab, disable cache, and throttle to the slowest speed you can
  • Open the delete dialog for a domain and while it is still fetching, hover over the close icon
  • The text tooltip should not display unknown
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@hana-akamai hana-akamai self-assigned this Aug 14, 2025
@hana-akamai hana-akamai added the Bug Fixes for regressions or bugs label Aug 14, 2025
@hana-akamai
hana-akamai marked this pull request as ready for review August 14, 2025 17:06
@hana-akamai
hana-akamai requested a review from a team as a code owner August 14, 2025 17:06
@hana-akamai
hana-akamai requested review from bill-akamai and harsh-akamai and removed request for a team August 14, 2025 17:06
@mjac0bs
mjac0bs self-requested a review August 14, 2025 17:13

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't seem to repro with network throttling, but I read through the code and had a look at the domain dialog manually.

Changes look good overall, just noticed a couple things.

Comment thread packages/manager/src/features/Domains/DomainsLanding.tsx
Comment thread packages/manager/src/features/Domains/DomainsLanding.tsx Outdated
@hana-akamai
hana-akamai requested a review from a team as a code owner August 15, 2025 16:17
@hana-akamai
hana-akamai requested review from dmcintyr-akamai and removed request for a team August 15, 2025 16:17
Comment thread packages/manager/src/features/Domains/DeleteDomainDialog.tsx

@bill-akamai bill-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @hana-akamai, confirmed steps ✔️

@hana-akamai hana-akamai added Add'tl Approval Needed Waiting on another approval! and removed Work in Progress labels Aug 15, 2025

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hana!

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Aug 15, 2025
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 15, 2025
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 2 failing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing715 Passing5 Skipped131m 31s

Details

Failing Tests
SpecTest
access-key.e2e.spec.tsCloud Manager Cypress Tests→object storage access key end-to-end tests » "before all" hook for "can create an access key with unlimited access - e2e"
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » delete disk

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts"

@hana-akamai
hana-akamai merged commit 8af48ab into linode:develop Aug 15, 2025
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Aug 15, 2025
@hana-akamai
hana-akamai deleted the M3-9034-delete-domain-dialog branch August 15, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants