test: [M3-10369] - Add tests to linode alerts edit page on when "Save Changes?" dialog should appear - #12707
Merged
dmcintyr-akamai merged 12 commits intoAug 18, 2025
Conversation
recd an error while running the changeset cmd locally, so i didnt realize i uploaded the file
recd an error while running the changeset cmd locally, so i didnt realize i uploaded the file
dmcintyr-akamai
marked this pull request as ready for review
August 15, 2025 14:17
dmcintyr-akamai
requested review from
cliu-akamai,
coliu-akamai,
dwiley-akamai and
pmakode-akamai
and removed request for
a team
August 15, 2025 14:17
Cloud Manager UI test results🎉 721 passing tests on test run #8 ↗︎
|
pmakode-akamai
added
ACLP Integration
pmakode-akamai
approved these changes
Aug 18, 2025
pmakode-akamai
left a comment
pmakode-akamai
left a comment
Contributor
There was a problem hiding this comment.
All tests pass ✅ thank you!
coliu-akamai
approved these changes
Aug 18, 2025
coliu-akamai
left a comment
coliu-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ confirmed tests pass
thanks @dmcintyr-akamai!
This was referenced Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add tests to linode alerts edit page (/linodes//alerts) on when "Save Changes?" dialog should appear. @pmakode-akamai documented in https://jira.linode.com/browse/M3-10369 the conditions on when the dialog should and should not appear.
In a region that supports alerts, the user will see the dialog if:
The user will NOT see the dialog if:
Changes 🔄
Added tests. Also replaced a string in one of the react components. This string was problematic bc it was padded w/ an extra space at the end, which made test assertions difficult.
How to test 🧪
pnpm run cy:run -s cypress/e2e/core/linodes/alerts-edit.spec.ts
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅