Skip to content

feat: [UIE-9079] - IAM RBAC: fix perm check for nodebalancer - #12719

Merged
abailly-akamai merged 2 commits into
linode:developfrom
aaleksee-akamai:UIE-9079-fix-remove-nodebalancer-permission
Aug 20, 2025
Merged

feat: [UIE-9079] - IAM RBAC: fix perm check for nodebalancer#12719
abailly-akamai merged 2 commits into
linode:developfrom
aaleksee-akamai:UIE-9079-fix-remove-nodebalancer-permission

Conversation

@aaleksee-akamai

@aaleksee-akamai aaleksee-akamai commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Description 📝

This PR fixes the IAM permission check for nodebalancer.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Update the permission check depending on the device type

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

August 26

Preview 📷

Before After
image image

How to test 🧪

Prerequisites

(How to setup test environment)

  • MSW or iam (restricted) + regular account to compare
    Permissions to check:
    Custom User Entity Permissions preset:
[
    'delete_firewall_device',
    'update_linode',
]

Verification steps

(How to verify changes)

  • Confirm the buttons/inputs are disabled according the grant model with IAM is off, and according to the RBAC model when IAM is on.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@kwojtowiakamai kwojtowiakamai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The "Remove" button in RemoveDeviceDialog is correctly enabled for both IAM and non-IAM users.

The button is not disabled if the user doesn’t have permissions for a nodebalancer, but since nodebalancers aren’t migrated to RBAC yet this is fine for now. (as we discussed in Webex)

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 724 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing724 Passing4 Skipped115m 0s

@corya-akamai corya-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 19, 2025
@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Aug 19, 2025
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should this be considered a bug fix? If not, maybe we should say "adjust" instead of "fix" in the description

@abailly-akamai
abailly-akamai merged commit ac0cc69 into linode:develop Aug 20, 2025
35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! IAM (Identity & Access Management)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants