feat: [UIE-9079] - IAM RBAC: fix perm check for nodebalancer - #12719
Merged
abailly-akamai merged 2 commits intoAug 20, 2025
Merged
Conversation
aaleksee-akamai
requested review from
dwiley-akamai and
mjac0bs
and removed request for
a team
August 19, 2025 07:24
kwojtowiakamai
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
✅ The "Remove" button in RemoveDeviceDialog is correctly enabled for both IAM and non-IAM users.
The button is not disabled if the user doesn’t have permissions for a nodebalancer, but since nodebalancers aren’t migrated to RBAC yet this is fine for now. (as we discussed in Webex)
Cloud Manager UI test results🎉 724 passing tests on test run #2 ↗︎
|
corya-akamai
approved these changes
Aug 19, 2025
mjac0bs
approved these changes
Aug 19, 2025
dwiley-akamai
approved these changes
Aug 19, 2025
Contributor
There was a problem hiding this comment.
nit: should this be considered a bug fix? If not, maybe we should say "adjust" instead of "fix" in the description
This was referenced Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR fixes the IAM permission check for nodebalancer.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
August 26
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Permissions to check:
Custom User Entity Permissionspreset:Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅