Skip to content

feat: [UIE-8560, UIE-8978] - IAM RBAC: User Detail UI fix, Tooltip for Linode Storage Action menu #12722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abailly-akamai merged 7 commits into from
Aug 20, 2025
Merged

feat: [UIE-8560, UIE-8978] - IAM RBAC: User Detail UI fix, Tooltip for Linode Storage Action menu #12722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eebc0e2
feat: [UIE-8560, UIE-8978] - IAM RBAC: User Detail ui fix, no permiss…
mpolotsk-akamai Aug 19, 2025
6bce692
add tooltip for rename and clone
mpolotsk-akamai Aug 19, 2025
1ef8e33
Added changeset: IAM RBAC: User Detail UI fix, add missing tooltips t…
mpolotsk-akamai Aug 19, 2025
c506c3a
unit test fix
mpolotsk-akamai Aug 19, 2025
bcdbd25
unit test fix
mpolotsk-akamai Aug 19, 2025
2fce3e1
fix after review
mpolotsk-akamai Aug 20, 2025
d2fe2bf
fix e2e
mpolotsk-akamai Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-12722-upcoming-features-1755612928561.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Upcoming Features
---

IAM RBAC: User Detail UI fix, add missing tooltips to Linode Storage Action Menu ([#12722](https://github.com/linode/manager/pull/12722))
2 changes: 1 addition & 1 deletion packages/manager/cypress/e2e/core/linodes/linode-storage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const deleteInUseDisk = (diskName: string) => {
});

cy.findByText(
'Your Linode must be fully powered down in order to perform this action'
'Your Linode must be fully powered down in order to perform this action.'
).should('be.visible');
};

Expand Down
14 changes: 7 additions & 7 deletions packages/manager/src/features/IAM/Users/UserDetails/UserDetailsPanel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ describe('UserDetailsPanel', () => {
<UserDetailsPanel assignedRoles={assignedRoles} user={user} />
);

expect(getByText('Username')).toBeVisible();
expect(getByText(/Username/)).toBeVisible();
expect(getByText(user.username)).toBeVisible();

expect(getByText('Email')).toBeVisible();
expect(getByText(/Email/)).toBeVisible();
expect(getByText(user.email)).toBeVisible();
});

Expand All @@ -31,7 +31,7 @@ describe('UserDetailsPanel', () => {
<UserDetailsPanel assignedRoles={assignedRoles} user={user} />
);

expect(getByText('Assigned Roles')).toBeVisible();
expect(getByText(/Assigned Roles/)).toBeVisible();
expect(getAllByText('0')[0]).toBeVisible();
});

Expand Down Expand Up @@ -61,7 +61,7 @@ describe('UserDetailsPanel', () => {
<UserDetailsPanel assignedRoles={assignedRoles} user={user} />
);

expect(getByText('Assigned Roles')).toBeVisible();
expect(getByText(/Assigned Roles/)).toBeVisible();
expect(getByText('7')).toBeVisible();
});

Expand All @@ -82,7 +82,7 @@ describe('UserDetailsPanel', () => {
<UserDetailsPanel assignedRoles={assignedRoles} user={user} />
);

expect(getByText('Assigned Roles')).toBeVisible();
expect(getByText(/Assigned Roles/)).toBeVisible();
expect(getByText('4')).toBeVisible();
});

Expand All @@ -96,7 +96,7 @@ describe('UserDetailsPanel', () => {
<UserDetailsPanel assignedRoles={assignedRoles} user={user} />
);

expect(getByText('Verified Phone Number')).toBeVisible();
expect(getByText(/Verified number/)).toBeVisible();
expect(getByText(user.verified_phone_number!)).toBeVisible();
});

Expand All @@ -108,7 +108,7 @@ describe('UserDetailsPanel', () => {
<UserDetailsPanel assignedRoles={assignedRoles} user={user} />
);

expect(getByText('2FA')).toBeVisible();
expect(getByText(/2FA/)).toBeVisible();
expect(getByText('Enabled')).toBeVisible();
});
});
8 changes: 5 additions & 3 deletions packages/manager/src/features/IAM/Users/UserDetails/UserDetailsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,14 @@ export const UserDetailsPanel = ({ assignedRoles, user }: Props) => {
status={
user.last_login?.status === 'successful' ? 'active' : 'error'
}
sx={{ alignSelf: 'center' }}
/>
)}
</Stack>
),
},
{
label: 'Last Login',
label: 'Last login',
value: user.last_login ? (
<DateTimeDisplay value={user.last_login.login_datetime} />
) : (
Expand All @@ -74,7 +75,7 @@ export const UserDetailsPanel = ({ assignedRoles, user }: Props) => {
),
},
{
label: 'Verified Phone Number',
label: 'Verified number',
value: (
<MaskableText
isToggleable
Expand Down Expand Up @@ -116,6 +117,7 @@ export const UserDetailsPanel = ({ assignedRoles, user }: Props) => {
'& > p:nth-of-type(2)': {
overflow: 'hidden',
textOverflow: 'ellipsis',
alignItems: 'center',
},
}}
>
Expand All @@ -124,7 +126,7 @@ export const UserDetailsPanel = ({ assignedRoles, user }: Props) => {
font: theme.font.bold,
})}
>
{item.label}
{item.label}:
</Typography>
{item.value}
</Stack>
Expand Down
9 changes: 8 additions & 1 deletion ...es/manager/src/features/Linodes/LinodesDetail/LinodeStorage/LinodeDiskActionMenu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,13 @@ describe('LinodeDiskActionMenu', () => {
});

it('should disable Resize and Delete when the Linode is running', async () => {
queryMocks.userPermissions.mockReturnValue({
data: {
...queryMocks.userPermissions().data,
resize_linode: true,
delete_linode: true,
},
});
const { getAllByLabelText, getByLabelText } = renderWithTheme(
<LinodeDiskActionMenu {...defaultProps} />
);
Expand All @@ -169,7 +176,7 @@ describe('LinodeDiskActionMenu', () => {

expect(
getAllByLabelText(
'Your Linode must be fully powered down in order to perform this action'
'Your Linode must be fully powered down in order to perform this action.'
)
).toHaveLength(2);
});
Expand Down
17 changes: 13 additions & 4 deletions packages/manager/src/features/Linodes/LinodesDetail/LinodeStorage/LinodeDiskActionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,25 +40,31 @@ export const LinodeDiskActionMenu = (props: Props) => {

@coliu-akamai coliu-akamai Aug 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note - My limited iam account has the role linode_viewer for one of my Linodes, and I see this for the disk's action menu - Create Disk Image is also disabled but there's no tooltip:

image

@mpolotsk-akamai mpolotsk-akamai Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tooltip for the Create Disk Image. Thanks!

const poweredOnTooltip =
linodeStatus !== 'offline'
? 'Your Linode must be fully powered down in order to perform this action'
? 'Your Linode must be fully powered down in order to perform this action.'
: undefined;

const swapTooltip =
disk.filesystem == 'swap'
? 'You cannot create images from Swap images.'
: undefined;

const noPermissionTooltip =
'You do not have permission to perform this action.';

const actions: Action[] = [
{
disabled: !permissions.update_linode,
onClick: onRename,
title: 'Rename',
tooltip: !permissions.update_linode ? noPermissionTooltip : undefined,
},
{
disabled: !permissions.resize_linode || linodeStatus !== 'offline',
onClick: onResize,
title: 'Resize',
tooltip: poweredOnTooltip,
tooltip: !permissions.resize_linode
? noPermissionTooltip
: poweredOnTooltip,
},
{
disabled: readOnly || !!swapTooltip,
Expand All @@ -71,7 +77,7 @@ export const LinodeDiskActionMenu = (props: Props) => {
},
}),
title: 'Create Disk Image',
tooltip: swapTooltip,
tooltip: readOnly ? noPermissionTooltip : swapTooltip,
},
{
disabled: !permissions.clone_linode,
Expand All @@ -83,13 +89,16 @@ export const LinodeDiskActionMenu = (props: Props) => {
},
});
},
tooltip: !permissions.clone_linode ? noPermissionTooltip : undefined,
title: 'Clone',
},
{
disabled: !permissions.delete_linode || linodeStatus !== 'offline',
onClick: onDelete,
title: 'Delete',
tooltip: poweredOnTooltip,
tooltip: !permissions.delete_linode
? noPermissionTooltip
: poweredOnTooltip,
},
];

Expand Down