fix: [M3-10501, M3-10477] - Disable Maintenance Policy Select for Unsupported Regions - #12725
Merged
Conversation
jaalah-akamai
requested review from
dwiley-akamai and
harsh-akamai
and removed request for
a team
August 19, 2025 15:28
jaalah-akamai
requested review from
mjac0bs
and removed request for
harsh-akamai
August 19, 2025 15:30
bnussman-akamai
approved these changes
Aug 19, 2025
bnussman-akamai
approved these changes
Aug 19, 2025
bnussman-akamai
left a comment
Member
There was a problem hiding this comment.
Looks good pending CI passes
mjac0bs
approved these changes
Aug 19, 2025
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
Looks good, speedy fix. 🚀
- Observed the previous issue of changes to the policy seemingly not saving.
- Confirmed Maintenance Policy selection is enabled/disabled depending on supported region.
- Confirmed that for a supported region, Maintenance Policy can be updated and saved. Setting persists.
- Confirmed copy changes look good, no issues.
| region with capability | region w/o capability |
|---|---|
![]() |
![]() |
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
| render={({ field, fieldState }) => ( | ||
| <MaintenancePolicySelect | ||
| disabled={isReadOnly} | ||
| disabled={isReadOnly || !regionSupportsMaintenancePolicy} |
Member
There was a problem hiding this comment.
Should we add a tooltip explaining why the component is disabled?
Suggested change
| disabled={isReadOnly || !regionSupportsMaintenancePolicy} | |
| disabled={isReadOnly || !regionSupportsMaintenancePolicy} | |
| textFieldProps={{ | |
| tooltipText: isReadOnly | |
| ? getRestrictedResourceText({ | |
| resourceType: 'Linodes', | |
| isSingular: true, | |
| action: 'edit', | |
| includeContactInfo: false, | |
| }) | |
| : !regionSupportsMaintenancePolicy | |
| ? "This Linode's region does not support maintenance policies." | |
| : undefined, | |
| }} |
Related to the bug I commented about above, we should probably remove You don't have permission to change this setting copy from the MaintenancePolicySelect component itself and have the parent provide it or maybe we add a new prop to MaintenancePolicySelect called hasPermission or something and keep the logic
Contributor
Author
There was a problem hiding this comment.
Good call thanks
jaalah-akamai
requested review from
dmcintyr-akamai
and removed request for
a team
August 20, 2025 17:59
Contributor
Author
Cloud Manager UI test results🔺 1 failing test on test run #11 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/maintenance-policy-region-support.spec.ts" |
|||||||||||||||||
bill-akamai
approved these changes
Aug 20, 2025
bnussman-akamai
approved these changes
Aug 20, 2025
This was referenced Aug 21, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description 📝
The maintenance policy dropdown remains enabled in Linode detail settings even when the feature isn't supported in the Linode's region. This misleads users into attempting to modify an unavailable setting.
Impact: UX confusion only - no production impact.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
8/26
Preview 📷
How to test 🧪
Reproduction steps
(How to reproduce the issue, if applicable)
migrateby default (works as it should for unsupported regions)Verification step
maintenance_policyupdates accordinglyAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅