Skip to content

upcoming: [M3-10486] - Update dual-stack labeling in VPC Create #12746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hana-akamai merged 2 commits into from
Aug 22, 2025
Merged

upcoming: [M3-10486] - Update dual-stack labeling in VPC Create #12746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
871f04c
update dual stack labeling in vpc create
hana-akamai Aug 21, 2025
75a84e7
Added changeset: Update dual-stack labeling in VPC Create
hana-akamai Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-12746-upcoming-features-1755808123912.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Upcoming Features
---

Update dual-stack labeling in VPC Create ([#12746](https://github.com/linode/manager/pull/12746))

@dwiley-akamai dwiley-akamai Aug 22, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Update dual-stack labeling in VPC Create ([#12746](https://github.com/linode/manager/pull/12746))
Update dual-stack labeling on VPC Create page ([#12746](https://github.com/linode/manager/pull/12746))

10 changes: 5 additions & 5 deletions packages/manager/src/features/VPCs/VPCCreate/FormComponents/VPCTopSectionContent.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ describe('VPC Top Section form content', () => {
expect(screen.getByText('VPC Label')).toBeVisible();
expect(screen.getByText('Description')).toBeVisible();
// @TODO VPC IPv6: Remove this check once VPC IPv6 is in GA
expect(screen.queryByText('Networking IP Stack')).not.toBeInTheDocument();
expect(screen.queryByText('IP Stack')).not.toBeInTheDocument();
});

it('renders a Networking IP Stack section with IPv4 pre-checked if the vpcIpv6 feature flag is enabled', async () => {
it('renders an IP Stack section with IPv4 pre-checked if the vpcIpv6 feature flag is enabled', async () => {
const account = accountFactory.build({
capabilities: ['VPC Dual Stack'],
});
Expand All @@ -66,7 +66,7 @@ describe('VPC Top Section form content', () => {
});

await waitFor(() => {
expect(screen.getByText('Networking IP Stack')).toBeVisible();
expect(screen.getByText('IP Stack')).toBeVisible();
});

const NetworkingIPStackRadios = screen.getAllByRole('radio');
Expand Down Expand Up @@ -100,7 +100,7 @@ describe('VPC Top Section form content', () => {
});

await waitFor(() => {
expect(screen.getByText('Networking IP Stack')).toBeVisible();
expect(screen.getByText('IP Stack')).toBeVisible();
});

const NetworkingIPStackRadios = screen.getAllByRole('radio');
Expand Down Expand Up @@ -140,7 +140,7 @@ describe('VPC Top Section form content', () => {
});

await waitFor(() => {
expect(screen.getByText('Networking IP Stack')).toBeVisible();
expect(screen.getByText('IP Stack')).toBeVisible();
});

const NetworkingIPStackRadios = screen.getAllByRole('radio');
Expand Down
4 changes: 2 additions & 2 deletions packages/manager/src/features/VPCs/VPCCreate/FormComponents/VPCTopSectionContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export const VPCTopSectionContent = (props: Props) => {
/>
{isDualStackEnabled && (
<Box marginTop={2}>
<FormLabel>Networking IP Stack </FormLabel>
<FormLabel>IP Stack </FormLabel>
<Controller
control={control}
name="ipv6"
Expand Down Expand Up @@ -189,7 +189,7 @@ export const VPCTopSectionContent = (props: Props) => {
sm: 12,
xs: 12,
}}
heading="IPv4 + IPv6 (Dual Stack)"
heading="IPv4 + IPv6 (dual-stack)"
onClick={() => {
field.onChange([
{
Expand Down