staging hotfix: [UIE-9137] - AssignSelectedRolesDrawer user selection state issue - #12748
Merged
Conversation
abailly-akamai
marked this pull request as ready for review
August 22, 2025 11:54
abailly-akamai
requested review from
aaleksee-akamai,
dwiley-akamai,
hasyed-akamai and
mpolotsk-akamai
and removed request for
a team
August 22, 2025 11:54
aaleksee-akamai
approved these changes
Aug 22, 2025
Contributor
|
looks good, the issue has beed resolved, thanks @abailly-akamai |
kwojtowiakamai
approved these changes
Aug 22, 2025
kwojtowiakamai
left a comment
There was a problem hiding this comment.
Looks good. Thanks for fixing it so quickly! @abailly-akamai
mpolotsk-akamai
approved these changes
Aug 22, 2025
Cloud Manager UI test results🎉 735 passing tests on test run #2 ↗︎
|
coliu-akamai
approved these changes
Aug 22, 2025
coliu-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ confirmed no more refetching
✅ confirmed fix
thanks @abailly-akamai!
bnussman-akamai
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR fixes a couple issues with the behavior of the
AssignSelectedRolesDrawercomponent - specifically the user selection.Prior to this fix we would encounter two issues:
While a dedicated state input state was the right model, there was no need for detaching the actual username from the form state
Changes 🔄
AssignSelectedRolesDrawerstate 👉 rely on form state for actual usernameScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️ 8/26/2025
Preview 📷
How to test 🧪
Prerequisites
IAM account with permission to assign roles to another user
Reproduction steps
Verification steps
Also confirm fetching by any username still works ✅
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅