Skip to content

fix: [M3-10533] - Fix misleading "Receive a transfer" tooltip when user lacks permissions - #12813

Merged
coliu-akamai merged 6 commits into
linode:developfrom
coliu-akamai:m3-10533
Sep 8, 2025
Merged

fix: [M3-10533] - Fix misleading "Receive a transfer" tooltip when user lacks permissions#12813
coliu-akamai merged 6 commits into
linode:developfrom
coliu-akamai:m3-10533

Conversation

@coliu-akamai

Copy link
Copy Markdown
Contributor

Description 📝

  • Update tooltip for user who doesn't have permissions
  • Disable token textfield when user lacks permissions

todo: add tests

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Before After
image image

How to test 🧪

  • Use an account with a user who lacks permissions to accept service transfers
  • Use an account with a user who has permissions

Verification steps

  • Confirm for the user w/o permissions, the copy is updated to say so
  • Confirm if user has permissions, copy still says 'Enter a ...'
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@coliu-akamai coliu-akamai self-assigned this Sep 4, 2025
@coliu-akamai coliu-akamai added the Bug Fixes for regressions or bugs label Sep 4, 2025
Comment on lines +82 to +83
? 'You do not have permission to receive service transfers.'
: 'Enter a service transfer token to review the details and accept the transfer.'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tooltip texts for lacking permissions is pretty inconsistent - I'm seeing both "you do not have permissions..." and "you don't have permission(s)...". I went with "you do not have permission" bc this is in line with a lot of recent IAM changes. Will put a topic on frontend cafe to see if we want to make messaging more consistent tho!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also an effort I brought forward with UX to bring consistency to both the messaging AND the error handling of not having permissions. Hopefully this will improve things, we're meeting today

@coliu-akamai
coliu-akamai marked this pull request as ready for review September 4, 2025 16:49
@coliu-akamai
coliu-akamai requested a review from a team as a code owner September 4, 2025 16:49
@coliu-akamai
coliu-akamai requested review from bnussman-akamai and hana-akamai and removed request for a team September 4, 2025 16:49

@bnussman-akamai bnussman-akamai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thanks 🙏

@jdamore-linode jdamore-linode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Connie, looks great!

Confirmed that the permissions tooltip text appears when the user lacks permissions (and that the service token text field is disabled now, too!):

Screenshot 2025-09-04 at 1 28 23 PM

And confirmed that the existing tooltip text still appears when the user has permissions but hasn't entered a token:

Screenshot 2025-09-04 at 1 26 44 PM

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Sep 4, 2025
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 738 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing738 Passing6 Skipped43m 52s

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Sep 4, 2025
@coliu-akamai
coliu-akamai merged commit e6bc7a1 into linode:develop Sep 8, 2025
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Sep 8, 2025
@coliu-akamai
coliu-akamai deleted the m3-10533 branch September 8, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants