fix: [M3-10533] - Fix misleading "Receive a transfer" tooltip when user lacks permissions - #12813
Merged
Merged
Conversation
coliu-akamai
commented
Sep 4, 2025
Comment on lines
+82
to
+83
| ? 'You do not have permission to receive service transfers.' | ||
| : 'Enter a service transfer token to review the details and accept the transfer.' |
Contributor
Author
There was a problem hiding this comment.
tooltip texts for lacking permissions is pretty inconsistent - I'm seeing both "you do not have permissions..." and "you don't have permission(s)...". I went with "you do not have permission" bc this is in line with a lot of recent IAM changes. Will put a topic on frontend cafe to see if we want to make messaging more consistent tho!
Contributor
There was a problem hiding this comment.
There's also an effort I brought forward with UX to bring consistency to both the messaging AND the error handling of not having permissions. Hopefully this will improve things, we're meeting today
coliu-akamai
marked this pull request as ready for review
September 4, 2025 16:49
coliu-akamai
requested review from
bnussman-akamai and
hana-akamai
and removed request for
a team
September 4, 2025 16:49
jdamore-linode
approved these changes
Sep 4, 2025
Cloud Manager UI test results🎉 738 passing tests on test run #4 ↗︎
|
This was referenced Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description 📝
todo: add tests
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Include a screenshot
<img src="" />or video<video src="" />of the change.🔒 Use the Mask Sensitive Data setting for security.
💡 For changes requiring multiple steps to validate, prefer a video for clarity.
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅