upcoming: Hide new Volume count limit changes behind a feature flag - #12830
Merged
Conversation
coliu-akamai
marked this pull request as ready for review
September 5, 2025 20:03
coliu-akamai
requested review from
bill-akamai and
dwiley-akamai
and removed request for
a team
September 5, 2025 20:03
jdamore-linode
previously approved these changes
Sep 5, 2025
jdamore-linode
left a comment
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Thanks Connie! Approved pending CI
Contributor
Author
|
oops sorry @jdamore-linode - I just pushed up a change that I'd forgotten to save. could you reapprove? 🙏 |
jdamore-linode
previously approved these changes
Sep 5, 2025
Contributor
Author
|
ty! 🙏 |
cpathipa
previously approved these changes
Sep 5, 2025
bill-akamai
previously approved these changes
Sep 5, 2025
coliu-akamai
dismissed stale reviews from bill-akamai, cpathipa, and jdamore-linode
via
September 5, 2025 20:27
203ea2c
Contributor
Author
|
apologies, one more time please! 😅 |
bnussman-akamai
previously approved these changes
Sep 5, 2025
…igs/utilities.ts Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
coliu-akamai
requested review from
bill-akamai,
bnussman-akamai and
cpathipa
September 5, 2025 20:31
bnussman-akamai
approved these changes
Sep 5, 2025
jdamore-linode
approved these changes
Sep 5, 2025
bill-akamai
approved these changes
Sep 5, 2025
Cloud Manager UI test results🎉 740 passing tests on test run #5 ↗︎
|
cpathipa
added a commit
to cpathipa/manager
that referenced
this pull request
Sep 9, 2025
…e flag (linode#12830)" This reverts commit 4434034.
5 tasks
bnussman-akamai
added a commit
to bnussman-akamai/manager
that referenced
this pull request
Sep 9, 2025
…inode#12830) * add feature flag, clean up logic * add tests * update changelog + catch unsaved work * update tests * Update packages/manager/src/features/Linodes/LinodesDetail/LinodeConfigs/utilities.ts Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> --------- Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
There was a slight misunderstanding on the release date of #12791 - it should actually be hidden behind a feature flag, and not go out to everyone upon 9/9's release
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
9/9
Preview 📷
Linode config dialog - first row of images
Rescue dialog - second row
How to test 🧪
Create a Linode with 16gb ram
Use dev tools to toggle the
blockStorageVolumeLimitflagVerification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅