Skip to content

feat: [UIE-9166] - IAM RBAC: add a delay to Linodes menu - #12835

Merged
aaleksee-akamai merged 2 commits into
linode:developfrom
aaleksee-akamai:UIE-9166-iam-linodes-menu
Sep 9, 2025
Merged

feat: [UIE-9166] - IAM RBAC: add a delay to Linodes menu#12835
aaleksee-akamai merged 2 commits into
linode:developfrom
aaleksee-akamai:UIE-9166-iam-linodes-menu

Conversation

@aaleksee-akamai

Copy link
Copy Markdown
Contributor

Description 📝

We are requesting all permissions for every row on linodes landing. We should wait until the user clicks the action menu to fetch the permissions.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Add a delay for an action menu for checking permissions in Linodes

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

09/23

Preview 📷

Before After
image image
📷 image

How to test 🧪

Prerequisites

(How to setup test environment)

  • MSW or iam (restricted) + regular account to compare
  • navigate to /linodes

Verification steps

(How to verify changes)

  • Confirm that permissions are only requested once the user clicks the action menu
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai
aaleksee-akamai requested a review from a team as a code owner September 8, 2025 12:57
@aaleksee-akamai
aaleksee-akamai requested review from cpathipa and mjac0bs and removed request for a team September 8, 2025 12:57
@aaleksee-akamai aaleksee-akamai self-assigned this Sep 8, 2025
@aaleksee-akamai aaleksee-akamai added Linodes Dealing with the Linodes section of the app IAM (Identity & Access Management) labels Sep 8, 2025

@abailly-akamai abailly-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing - confirming this addresses over-fetching every linode permissions for a non account_admin IAM account

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 745 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing745 Passing6 Skipped40m 43s

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixed the ticketed issue and the requests are now made for each linode when an action menu is clicked, thanks @aaleksee-akamai.

Screen.Recording.2025-09-08.at.3.33.48.PM.mov

I didn't even realize we had a loading state on our action menu; I don't think I've ever seen it before.

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Sep 8, 2025
@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Sep 8, 2025
@aaleksee-akamai
aaleksee-akamai merged commit a0a2fa6 into linode:develop Sep 9, 2025
35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! IAM (Identity & Access Management) Linodes Dealing with the Linodes section of the app

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants