upcoming: [DI-22916] - Added group by drawer component - #12843
Merged
nikhagra-akamai merged 26 commits intoSep 11, 2025
Conversation
…et level dimension
nikhagra-akamai
requested review from
cpathipa and
mjac0bs
and removed request for
a team
September 9, 2025 14:17
| return { options: [], defaultValue: [], isLoading: true }; | ||
| } | ||
|
|
||
| const metricDimensions: GroupByOption[] = |
Contributor
There was a problem hiding this comment.
@nikhagra-akamai , lets add describing comments for the methods in this hook
venkymano-akamai
approved these changes
Sep 9, 2025
venkymano-akamai
left a comment
venkymano-akamai
left a comment
Contributor
There was a problem hiding this comment.
LGTM, Lets add describing comments for the methods in the hook that is created
mjac0bs
reviewed
Sep 10, 2025
mjac0bs
approved these changes
Sep 11, 2025
mjac0bs
left a comment
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing feedback, @nikhagra-akamai.
| > | ||
| {subtitle} | ||
| </Typography> | ||
| <Typography sx={(theme) => ({ font: theme.font.normal })}> |
Contributor
There was a problem hiding this comment.
Suggested change
| <Typography sx={(theme) => ({ font: theme.font.normal })}> | |
| <Typography> |
nit: The font is already normal-sized without this styling rule since it's regular Typography text.
Contributor
Author
There was a problem hiding this comment.
updated thanks
mjac0bs
added
Approved
Cloud Manager UI test results🎉 746 passing tests on test run #11 ↗︎
|
This was referenced Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Added a group by drawer component for ACLP Metric UI
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
23rd September
Preview 📷
Note
This PR does not contains any visual changes. But added a component for new functionality that will be added in next PRs
This is the mockup for this feature: https://www.figma.com/design/2x7VRVdgrjegSJ5lFxoKMv/Standard-Dashboards?node-id=12858-53465&t=Hi2JXFU1Se2Vhlc4-0
How to test 🧪
useGlobalDimensionshook to generate the options from mock data.<CloudPulseGroupByDrawer defaultValue={[]} message={'Message'} onApply={(value) => {}} onCancel={() => {}} open={true} options={[]} serviceType="dbaas" subtitle="SubTitle" title="Global Group By" />Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅