upcoming: [M3-10389] - Feature flag New Chip and Beta Chip for Linode Interfaces - #12846
Merged
bnussman-akamai merged 7 commits intoSep 12, 2025
Conversation
bnussman-akamai
marked this pull request as ready for review
September 10, 2025 13:29
bnussman-akamai
requested review from
coliu-akamai and
dwiley-akamai
and removed request for
a team
September 10, 2025 13:29
coliu-akamai
approved these changes
Sep 10, 2025
coliu-akamai
left a comment
coliu-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ beta chips when feature is using beta flag
✅ new chips when feature is using new flag
I didn't see any other spots where we use a beta chip for Linode interfaces ✅
thanks @bnussman-akamai! one qq below
Cloud Manager UI test results🎉 745 passing tests on test run #5 ↗︎
|
dwiley-akamai
approved these changes
Sep 12, 2025
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
Correct chip shows in the specified locations depending on which sub-flag is toggled ✅
Code review ✅
bnussman-akamai
added
Approved
This was referenced Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
NewandBetachips to be toggled via feature flagsScope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Beta Chip
This is the current UI because the feature is in beta right now
New Chip
This is what the UI will look like in a few weeks once we toggle the feature flag
How to test 🧪
betaandnewflags underlinodeInterfacesAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅