upcoming: [DI-27104] - Added GlobalFilter and WidgetFilter group by renderer components - #12865
Merged
nikhagra-akamai merged 51 commits intoSep 16, 2025
Merged
Conversation
…et level dimension
venkymano-akamai
approved these changes
Sep 12, 2025
venkymano-akamai
left a comment
Contributor
There was a problem hiding this comment.
LGTM, pending my comments
… into feature/group-by
mjac0bs
approved these changes
Sep 15, 2025
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
Group by icons render the correct state when expected.
I left a couple points of minor feedback.
| </CloudPulseTooltip> | ||
|
|
||
| {!isDisabled && ( | ||
| <CloudPulseGroupByDrawer |
Contributor
There was a problem hiding this comment.
Not part of this PR, but noting that this pre-existing drawer has spacing inconsistent with the mocks. Mocks suggest 24px, and current spacing is variable, but more than that. This is partially due to a Stack gap that looks like it should be 3, not 4. (32px above the description, 32px + 16px below it, due to the Dimensions label top margin) in the rendered drawer.
Contributor
Author
There was a problem hiding this comment.
thanks for pointing out. I've updated stack gap
cpathipa
approved these changes
Sep 15, 2025
Cloud Manager UI test results🎉 809 passing tests on test run #8 ↗︎
|
This was referenced Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description 📝
Added GlobalFilter and WidgetFilter group by renderer components.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
23rd September
Preview 📷
Note
This PR does not contains any visual changes. But added a component for new functionality that will be added in next PRs
This is the mockup for this feature: https://www.figma.com/design/2x7VRVdgrjegSJ5lFxoKMv/Standard-Dashboards?node-id=12858-53465&t=Hi2JXFU1Se2Vhlc4-0
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅