Skip to content

fix: [DI-27269] - Updated tooltip per second unit in widget graphs - #12872

Merged
mjac0bs merged 7 commits into
linode:developfrom
nikhagra-akamai:graph-tooltip-fix
Sep 15, 2025
Merged

fix: [DI-27269] - Updated tooltip per second unit in widget graphs#12872
mjac0bs merged 7 commits into
linode:developfrom
nikhagra-akamai:graph-tooltip-fix

Conversation

@nikhagra-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Fixed wrong unit shown for per second units in CloudPulse widget graph tooltips

Changes 🔄

List any change(s) relevant to the reviewer.

  1. Updated CloudPulseWidget component to pass correct unit.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Before After
Screenshot 2025-09-12 at 12 30 35 PM Screenshot 2025-09-12 at 12 29 26 PM

How to test 🧪

  1. Switch to mock user
  2. Go to metric tab and select linode dashboards and all the required filters
  3. In the graph of Memory Usage you'll notice without the change in CloudPulseWidget component, tool tips will show B as unit instead of B/s which is fixed with this change.

Note

Please use the updated mock data present in this PR

Author Checklists

As an Author, to speed up the review process, I considered 🤔

Check all that apply

  •  Use React components instead of HTML Tags
  • Proper naming conventions like cameCase for variables & Function & snake_case for constants
  • Use appropriate types & avoid using "any"
  • No type casting & non-null assertions
  • Adding a changeset
  • Providing/Improving test coverage
  • Use sx props to pass styles instead of style prop
  • Add JSDoc comments for interface properties & functions
  • Use strict equality (===) instead of double equal (==)
  • Use of named arguments (interfaces) if function argument list exceeds size 2
  • Destructure the props
  • Keep component size small & move big computing functions to separate utility
  • 📱 Providing mobile support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@nikhagra-akamai
nikhagra-akamai requested a review from a team as a code owner September 12, 2025 13:47
@nikhagra-akamai
nikhagra-akamai requested review from coliu-akamai and mjac0bs and removed request for a team September 12, 2025 13:47
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 1 failing test on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing807 Passing10 Skipped39m 53s

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » "before all" hook for "can create and delete object storage buckets"

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed tooltip units are consistent with units in the graph title and table. Thanks for the fix!

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Sep 15, 2025
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Sep 15, 2025
@mjac0bs
mjac0bs merged commit be36904 into linode:develop Sep 15, 2025
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs Cloud Pulse - Dashboards Cloud Pulse

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants