Skip to content

test: [M3-10628] - Fix Cypress test failures after LKE-E Post LA flag was toggled on - #12883

Merged
mjac0bs merged 3 commits into
linode:developfrom
mjac0bs:M3-10628-fix-lke-e-test-after-post-la
Sep 16, 2025
Merged

mjac0bs merged 3 commits into
linode:developfrom
mjac0bs:M3-10628-fix-lke-e-test-after-post-la

Conversation

@mjac0bs

@mjac0bs mjac0bs commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Description 📝

We started seeing test failures since we turned the LKE-Enterprise postLa flag on in prod yesterday. Based on the screenshot, a couple of current tests haven't accounted for the change to the Node Pool plans table, which no longer has an enhanced number input increment/decrement button. That has been moved inside the Configure Pool drawer.

Changes 🔄

  • Update plan-selection.spec.ts to remove the check for the disabled increment/decrement buttons. Just a disabled Configure Pool button is visible now.
  • Update smoke-lke-standard-create.spec.ts to use the new LKE helper functions and correctly reference the Configure Pool button, rather than attempt to click the enhanced number input buttons in the plan row.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

9/23 - let's please get this in so that we don't have to deal with these test failures in the release

Preview 📷

Before After
image (29) image

How to test 🧪

Reproduction steps

(How to reproduce the issue, if applicable)

  • Check out develop and run these tests, or check the notifications Slack channel and observe the recent test failures

Verification steps

(How to verify changes)

  • Watch CI or check out this branch locally and:
pnpm cy:run -s "cypress/e2e/core/linodes/plan-selection.spec.ts,cypress/e2e/core/kubernetes/smoke-lke-standard-create.spec.ts"
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mjac0bs mjac0bs self-assigned this Sep 16, 2025
@mjac0bs mjac0bs changed the title test: [M3-10628] - Fix Cypress test failures after LKE-E PostLA flag was toggled on test: [M3-10628] - Fix Cypress test failures after LKE-E Post LA flag was toggled on Sep 16, 2025
@mjac0bs
mjac0bs marked this pull request as ready for review September 16, 2025 18:57
@mjac0bs
mjac0bs requested review from a team as code owners September 16, 2025 18:57
@mjac0bs
mjac0bs requested review from bill-akamai, dmcintyr-akamai, hana-akamai and jdamore-linode and removed request for a team September 16, 2025 18:57

@jdamore-linode jdamore-linode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjac0bs! Confirmed they're passing locally

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Sep 16, 2025
@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Sep 16, 2025
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 16, 2025

@hana-akamai hana-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that tests pass locally! 🚢

@mjac0bs
mjac0bs merged commit 3ce0bff into linode:develop Sep 16, 2025
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! LKE-Enterprise Testing 🚨 Urgent

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants