test: [M3-10628] - Fix Cypress test failures after LKE-E Post LA flag was toggled on - #12883
Merged
mjac0bs merged 3 commits intoSep 16, 2025
Merged
Conversation
mjac0bs
marked this pull request as ready for review
September 16, 2025 18:57
mjac0bs
requested review from
bill-akamai,
dmcintyr-akamai,
hana-akamai and
jdamore-linode
and removed request for
a team
September 16, 2025 18:57
jdamore-linode
approved these changes
Sep 16, 2025
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mjac0bs! Confirmed they're passing locally
cpathipa
approved these changes
Sep 16, 2025
bill-akamai
approved these changes
Sep 16, 2025
hana-akamai
approved these changes
Sep 16, 2025
hana-akamai
left a comment
Contributor
There was a problem hiding this comment.
Confirmed that tests pass locally! 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
We started seeing test failures since we turned the LKE-Enterprise
postLaflag on in prod yesterday. Based on the screenshot, a couple of current tests haven't accounted for the change to the Node Pool plans table, which no longer has an enhanced number input increment/decrement button. That has been moved inside the Configure Pool drawer.Changes 🔄
plan-selection.spec.tsto remove the check for the disabled increment/decrement buttons. Just a disabled Configure Pool button is visible now.smoke-lke-standard-create.spec.tsto use the new LKE helper functions and correctly reference the Configure Pool button, rather than attempt to click the enhanced number input buttons in the plan row.Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
9/23 - let's please get this in so that we don't have to deal with these test failures in the release
Preview 📷
How to test 🧪
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅