feat: [STORIF-102] - Volume "AttachedTo" column updated - #12903
Merged
bnussman-akamai merged 3 commits intoOct 6, 2025
Conversation
dchyrva-akamai
requested review from
bill-akamai and
bnussman-akamai
and removed request for
a team
September 23, 2025 09:54
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
3 times, most recently
from
September 23, 2025 10:01
8e84c66 to
2d44a0f
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
from
September 23, 2025 12:33
2d44a0f to
08dcbb2
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
2 times, most recently
from
September 23, 2025 13:08
927d232 to
01a687c
Compare
skulpok-akamai
approved these changes
Sep 23, 2025
bnussman-akamai
left a comment
Member
There was a problem hiding this comment.
Code looks great! I just have a few clean up items
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
2 times, most recently
from
September 25, 2025 08:07
8fb3c11 to
528d719
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
from
September 26, 2025 07:44
528d719 to
60018f6
Compare
skulpok-akamai
approved these changes
Sep 26, 2025
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
from
September 26, 2025 08:28
60018f6 to
c1b0ca5
Compare
bnussman-akamai
approved these changes
Sep 26, 2025
bnussman-akamai
left a comment
Member
There was a problem hiding this comment.
Code looks great! Left two non-blocking suggestions
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
from
September 29, 2025 08:06
c1b0ca5 to
6b42168
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
from
September 29, 2025 15:36
6b42168 to
9df14da
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
2 times, most recently
from
October 1, 2025 08:33
6639ac6 to
5d7fa54
Compare
dchyrva-akamai
requested review from
abailly-akamai
and removed request for
bill-akamai
October 1, 2025 14:13
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
4 times, most recently
from
October 2, 2025 14:39
a04fa40 to
4740b66
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
from
October 3, 2025 08:08
4740b66 to
485c8ad
Compare
abailly-akamai
approved these changes
Oct 6, 2025
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
from
October 6, 2025 10:11
485c8ad to
0e526ff
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-102
branch
from
October 6, 2025 12:03
0e526ff to
64f8274
Compare
Cloud Manager UI test results🔺 2 failing tests on test run #23 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/firewalls/create-firewall.spec.ts" |
||||||||||||||||||||
| * | ||
| * @TODO BSE: Remove optionality once BSE is fully rolled out | ||
| */ | ||
| encryption?: VolumeEncryption; // |
Member
There was a problem hiding this comment.
Suggested change
| encryption?: VolumeEncryption; // | |
| encryption?: VolumeEncryption; |
This was referenced Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Volume "AttachedTo" column updated.
Changes 🔄
Preview 📷
How to test 🧪
pnpm devcommand to start local environment.volume.io_ready = true;Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅