feat: [STORIF-106] - Object Storage Summary Tab - #12937
Merged
Merged
Conversation
dchyrva-akamai
force-pushed
the
feature/STORIF-106
branch
from
October 1, 2025 11:58
4737d83 to
4dfb6d5
Compare
dchyrva-akamai
marked this pull request as ready for review
October 1, 2025 12:52
dchyrva-akamai
force-pushed
the
feature/STORIF-106
branch
from
October 2, 2025 08:27
4dfb6d5 to
57fe040
Compare
dchyrva-akamai
requested review from
jdamore-linode
and removed request for
a team
October 2, 2025 08:27
dchyrva-akamai
marked this pull request as draft
October 2, 2025 08:43
dchyrva-akamai
force-pushed
the
feature/STORIF-106
branch
2 times, most recently
from
October 2, 2025 11:46
a49d57c to
765e2ac
Compare
dchyrva-akamai
marked this pull request as ready for review
October 2, 2025 11:46
dchyrva-akamai
force-pushed
the
feature/STORIF-106
branch
3 times, most recently
from
October 2, 2025 14:39
44fd9e3 to
a853be1
Compare
bnussman-akamai
changed the title
dchyrva-akamai
force-pushed
the
feature/STORIF-106
branch
4 times, most recently
from
October 6, 2025 13:40
d310579 to
83037bc
Compare
Member
|
Nice! I think it's great we're moving the Object Storage quotas to the correct place within Cloud Manager. Will we remove the https://cloud.linode.com/quotas page after this change? |
dwiley-akamai
approved these changes
Oct 6, 2025
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
Code review ✅
No OBJ regressions observed with feature flag off ✅
Functionality works as described with feature flag on ✅
Comment on lines
+20
to
+26
| sx={{ | ||
| backgroundColor: theme.bg.bgPaper, | ||
| padding: theme.spacingFunction(24), | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| gap: theme.spacingFunction(16), | ||
| }} |
Contributor
There was a problem hiding this comment.
optional: remove L12 and the useTheme import in favor of this:
Suggested change
| sx={{ | |
| backgroundColor: theme.bg.bgPaper, | |
| padding: theme.spacingFunction(24), | |
| display: 'flex', | |
| flexDirection: 'column', | |
| gap: theme.spacingFunction(16), | |
| }} | |
| sx={(theme) => ({ | |
| backgroundColor: theme.bg.bgPaper, | |
| padding: theme.spacingFunction(24), | |
| display: 'flex', | |
| flexDirection: 'column', | |
| gap: theme.spacingFunction(16), | |
| })} |
Contributor
Author
There was a problem hiding this comment.
Good idea, thank you.
dchyrva-akamai
force-pushed
the
feature/STORIF-106
branch
3 times, most recently
from
October 8, 2025 08:42
06338c3 to
0b627f1
Compare
bnussman-akamai
approved these changes
Oct 8, 2025
bnussman-akamai
left a comment
bnussman-akamai
left a comment
Member
There was a problem hiding this comment.
Let me know if you need any assistance configuring the objSummaryPage feature flag
dchyrva-akamai
force-pushed
the
feature/STORIF-106
branch
5 times, most recently
from
October 13, 2025 11:35
50db498 to
9fbc7f8
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-106
branch
from
October 13, 2025 14:28
9fbc7f8 to
24012b2
Compare
Cloud Manager UI test results🎉 838 passing tests on test run #21 ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Object Storage summary tab created.
Changes 🔄
List any change(s) relevant to the reviewer.
Preview 📷
How to test 🧪
pnpm dev.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅