feat: [UIE-9181] - DBaaS - Display hostname in summary tables based on VPC configuration and refactor connection details - #12939
Conversation
bnussman-akamai
left a comment
There was a problem hiding this comment.
Functionality is looking okay from my initial testing. I just have a few non-blocking changes. Will continue testing before giving my final ✅
| const { classes } = useStyles(); | ||
| const { enqueueSnackbar } = useSnackbar(); | ||
| const flags = useFlags(); | ||
| const isLegacy = database.platform !== 'rdbms-default'; |
There was a problem hiding this comment.
Non-blocking question: Do legacy databases even exist anymore? I was under the impression all Databases were migrated for all customers. The clean up of the legacy DBaaS code will be satisfying to see at some point
There was a problem hiding this comment.
@bnussman-akamai I'm not sure if they've been completely migrated from yet. We do have a clean up ticket for the legacy code though, UIE-8214. However that hasn't been pulled in yet. I'm also looking forward to when we get to clean up all this code in DBaaS.
If you want to make sure the legacy code is working, you can use the mock data and update the platform to `'rdbms-legacy' in the serverHandler. That's what I've been using to check since those can't be made anymore.
hana-akamai
left a comment
There was a problem hiding this comment.
Functionality is looking good, left some cleanup comments
27f0e6f to
91f7a55
Compare
…n VPC configuration and refactor connection details tables
91f7a55 to
8744daf
Compare
Cloud Manager UI test results🎉 832 passing tests on test run #6 ↗︎
|
Description 📝
This pull request updates the behavior for the
hostnamefield that appears in theConnection Detailstables in the Database Details Summary and Networking tabs. It also refactors these tables so that they're easier to manage via shared components.This following changes were made in this pull request:
1. Refactoring the Connection Details tables that appear in the Database Summary and Networking tabs
2. Updating the logic for the
Hostfield so that it displays different variations based on the Database Cluster VPC configuration.Host,Private Host, orPublic Hostbased on the configuration.ConnectionDetailsHostRowsshared component (See shared components list below)3. For the
Hostnamefields, the display behavior is now synced.Connection Detailstable now also appear for those same fields in the Networking tab table.The behavior for all fields except for the hostname fields should still be the same. The only change for them is that the row label and content is now passed down to the
ConnectionDetailsRowcomponent (For more info, see the shared components list below).Shared components created in DBaaS for this PR:
Host,Private Host,Public Host) using theConnectionDetailsRowChanges 🔄
List any change(s) relevant to the reviewer.
Hostfield so that it displays different variations based on the Database Cluster VPC configuration.Hostnamefields, the behavior for these fields is now synced. The tooltip and copy icon that appear in the Summary tab also appear for those same field in the Networking connection details table.Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
10/07/25
Preview 📷
Note: The before and after screenshots in each scenario show the Connection details tables in the Database Details Summary and Networking tab.
Scenario 1: Database Cluster with No VPC Configured displays
HostfieldSummary:
Networking:
Scenario 2. Database Cluster with VPC configured and Public Access set to
falsedisplaysPrivate HostfieldSummary:
Networking:
Scenario 3. Database Cluster with VPC configured and Public Access set to
truedisplays both thePrivate HostandPublic HostfieldsSummary:
Networking:
How to test 🧪
Prerequisites
(How to setup test environment)
databaseVpcfeature flag enabledNote 1: I'll provide mock data steps, so you can skip these if you prefer to use mock data.
Note 2: If creating databases, I suggest giving these databases names to indicate the state so they're easy to distinguish (ie. database-with-vpc-public)
Enable public accessfield checkboxcheckedEnable public accessfield checkboxuncheckedReproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Note: The
Readonly Hostfield is always displayed so it rendering isn't part of these scenarios for the hostname field changes. Only whether the icons for it display in networking.Note: You can use mock data to test the scenarios below. For mock data, you'll need to modify the database instance response to response to reflect each Database VPC configuration scenario. If you created the database clusters in staging, you can skip the mock data configuration steps.
Scenario 1. Database Cluster with No VPC Configured displays
Hostfieldprivate_networkproperty returned from the database instances request is null by default in the database.ts file on line 244 to:Connection Detailstable, theHostfield is displayed aboveRead-only Host(See Before/After screenshots above)Manage Networkingsection connection details table.Hostfield is displayed aboveRead-only Host.HostandRead-only Hostfield values as they appear for those fields in the in theSummarytab.Scenario 2. Database Cluster with VPC configured and Public Access set to false displays
Private Hostfieldprivate_networkproperty in the database.ts file on line 244 to:Connection Detailstable, thePrivate Hostfield is displayed aboveRead-only Host(See Before/After screenshots above)Manage Networkingsection connection details table.Private Hostfield is displayed displayed aboveRead-only Host.HostandRead-only Hostfield values as they appear for those fields in the in theSummarytab.Scenario 3. Database Cluster with VPC configured and Public Access set to true displays both the
Private HostandPublic Hostfieldsprivate_networkproperty in the database.ts file on line 244 to:Connection Detailstable, both thePrivate HostandPublic Hostfields are displayed aboveRead-only Hostin that order (See Before/After screenshots above)Public Hostfield, the hostname value starts withpublic-instead ofprivate-which is shown in thePrivate Hostfield hostname value.Manage Networkingsection connection details table.Private HostandPublic Hostfields are displayed aboveRead-only Hostin that order.Private Host,Public HostandRead-only Hostfield values as they appear for those fields in the in theSummarytab.4. Verify that the other non host-name fields still behave the same way after the refactor
Connection Detailstable in the Summary render the same way except for theHost,Private Host, and/orPublic HostandRead-only Hostfields where the display behavior has been updated in this PR.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅