feat: [UIE-9270] - IAM Delegation: Account Delegations Drawer - #12970
Merged
mpolotsk-akamai merged 6 commits intoOct 21, 2025
Merged
Conversation
mpolotsk-akamai
force-pushed
the
UIE-9270-account-delegation-drawer
branch
3 times, most recently
from
October 13, 2025 10:15
a68df62 to
9daaa42
Compare
mpolotsk-akamai
marked this pull request as ready for review
October 13, 2025 10:25
mpolotsk-akamai
added
the
IAM Delegation
abailly-akamai
left a comment
abailly-akamai
left a comment
Contributor
There was a problem hiding this comment.
I just did a quick code pass (haven't reviewed the UI yet) to try and improve some conventions.
Please let me know if you need any assistance in resolving some of those issues
mpolotsk-akamai
force-pushed
the
UIE-9270-account-delegation-drawer
branch
from
October 20, 2025 13:02
e3717bb to
87530c5
Compare
mpolotsk-akamai
force-pushed
the
UIE-9270-account-delegation-drawer
branch
from
October 20, 2025 13:29
87530c5 to
54c14b1
Compare
mpolotsk-akamai
commented
Oct 20, 2025
abailly-akamai
self-requested a review
October 21, 2025 07:58
| }); | ||
| queryClient.invalidateQueries({ | ||
| queryKey: delegationQueries.allChildAccounts._def, | ||
| }); |
Contributor
There was a problem hiding this comment.
@mpolotsk-akamai we were missing the ALL query invalidation
abailly-akamai
approved these changes
Oct 21, 2025
abailly-akamai
left a comment
abailly-akamai
left a comment
Contributor
There was a problem hiding this comment.
Great work!
Confirmed UI, validation, query invalidation and data flow ✅
Also pushed a couple fix needed for the mock data to behave properly
Cloud Manager UI test results🔺 1 failing test on test run #10 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
aaleksee-akamai
approved these changes
Oct 21, 2025
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Dec 8, 2025
…#12970) * feat: [UIE-9270] - IAM Delegation: Account Delegation Drawer * feat: [UIE-9270] - fix autocomplete, unit test * cleanup * Added changeset: IAM: Account Delegations Drawer * feat: [UIE-9270] - IAM Delegation: review fix * data handling fixes --------- Co-authored-by: Alban Bailly <abailly@akamai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR implements an Account Delegations Drawer for Account Delegation tab.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
October 21st
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅