Skip to content

fix: [DI-27690] - Time will not update on changing timezone with custom date - #12971

Merged
nikhagra-akamai merged 6 commits into
linode:developfrom
nikhagra-akamai:fix/time-range-picker
Oct 9, 2025
Merged

fix: [DI-27690] - Time will not update on changing timezone with custom date#12971
nikhagra-akamai merged 6 commits into
linode:developfrom
nikhagra-akamai:fix/time-range-picker

Conversation

@nikhagra-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Time will not update on changing timezone with custom date

Changes 🔄

List any change(s) relevant to the reviewer.

  1. Updated strategy keys in datetime range picker for presets
  2. Updated CloudPulseDateTimeRangePicker utils to use preset constant instead of hardcoding values

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

21st October

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Before After
Screen.Recording.2025-10-08.at.7.37.25.PM.mov
Screen.Recording.2025-10-08.at.7.37.58.PM.mov

How to test 🧪

Prerequisites

  1. Clone current linode/develop branch
  2. Go to metrics tab

Reproduction steps

  1. Select date picker
  2. Select custom date and time
  3. Change time zone. You'll notice that time also changing which should not happen

Verification steps

(How to verify changes)

  • Change timezone after selecting custom date and time. You'll notice, time is not changing
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@nikhagra-akamai
nikhagra-akamai requested a review from a team as a code owner October 8, 2025 14:23

@jaalah-akamai jaalah-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good and fix the timezone issues we were seeing ✅

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 8, 2025
@ankita-akamai

Copy link
Copy Markdown
Contributor

@agorthi-akamai can we get rid of commented out code lines in cypress files?

@ankita-akamai ankita-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Oct 9, 2025
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 2 failing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing836 Passing11 Skipped50m 1s

Details

Failing Tests
SpecTest
rebuild-linode.spec.tsCloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Account StackScript
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/rebuild-linode.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts"

@nikhagra-akamai
nikhagra-akamai merged commit 02a0496 into linode:develop Oct 9, 2025
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Oct 9, 2025
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Dec 8, 2025
…om date (linode#12971)

* fix: [DI-27690] - Time will not update on changing timezone with custom date

* fix: [DI-27690] - Updated preset strings with constants in cloud pulse time range picker utils

* added changeset

* Fix[DI-27693]: Fix: Restore GMT/UTC date-time validation logic in Cloudpulse timerange tests

---------

Co-authored-by: agorthi-akamai <agorthi@akamai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Add'tl Approval Needed Waiting on another approval! Bug Fixes for regressions or bugs Date Range Picker

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants