fix: [VMP-2536] - Maintenance date from local to utc - #13059
Merged
Conversation
Contributor
Author
|
Checking with team as to if we need to hotfix this to |
dmcintyr-akamai
approved these changes
Nov 12, 2025
…ng maintenance table
Cloud Manager UI test results🔺 5 failing tests on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/stackscripts/create-stackscripts.spec.ts,cypress/e2e/core/linodes/resize-linode.spec.ts,cypress/e2e/core/stackscripts/update-stackscripts.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/linodes/switch-linode-state.spec.ts" |
|||||||||||||||||||||||||||||
abailly-akamai
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect maintenance time display in the Upcoming maintenance table. The code was incorrectly adding
notification_period_secto thewhenfield to derive the start time. Thewhenandstart_timefields are equivalent timestamps representing when maintenance occurs, sowhenshould be used directly.Also improves time display accuracy by rounding up hours when minutes >= 30 (e.g., "1 day 3 hours 49 minutes" displays as "in 1 day 4 hours" instead of "in 1 day 3 hours").
Changes
whendirectly as the start time instead of addingnotification_period_secpoliciesparameter dependency fromderiveMaintenanceStartISOandgetUpcomingRelativeLabelMaintenanceTableRowcomponentwhenandstart_timeare equivalent timestampsScope
Upon production release, changes in this PR will be visible to:
Target release date
TBD
Preview
notification_period_secwhen the field already accounts for thiswhentimestampHow to test
Prerequisites
devcloudcx accountwhentimestamps andstart_time: nullReproduction steps
Verification steps
whentimestamp (notwhen + notification_period_sec)start_time: nullstart_timepopulated