-
Notifications
You must be signed in to change notification settings - Fork 407
upcoming:[DI-28000] - Handle LKE integration in metrics #13064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
cbe23dc
dd798c4
b746dc9
3df2c3d
3629596
526fd6c
fcb9d6b
921e7a8
8f3f844
88e6304
1b4cfb9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/api-v4": Upcoming Features | ||
| --- | ||
|
|
||
| CloudPulse-Metrics: Update `CloudPulseServiceType` and `CapabilityServiceTypeMapping` at types.ts for new service - lke ([#13064](https://github.com/linode/manager/pull/13064)) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/manager": Upcoming Features | ||
| --- | ||
|
|
||
| CloudPulse-Metrics: Update `FilterConfig.ts`, add lke service and the associated filters ([#13064](https://github.com/linode/manager/pull/13064)) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,7 @@ import type { | |
| Dimension, | ||
| Firewall, | ||
| FirewallDeviceEntity, | ||
| KubernetesCluster, | ||
| MonitoringCapabilities, | ||
| ResourcePage, | ||
| Service, | ||
|
|
@@ -587,3 +588,15 @@ export const filterFirewallResources = ( | |
| }) | ||
| ); | ||
| }; | ||
|
|
||
| /** | ||
| * @param clusters The list of kubernetes clusters | ||
| * @returns The filtered kubernetes clusters based on the tier | ||
| */ | ||
| export const filterKubernetesClusters = ( | ||
| clusters: KubernetesCluster[] | ||
| ): KubernetesCluster[] => { | ||
| return clusters | ||
| .filter(({ tier }) => tier === 'enterprise') | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does CloudPulse support API X-Filters? It may be better to X-Filter for enterprise clusters rather than client side filtering. It could help for large customers with tons of clusters.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bnussman-akamai It has been recommended from the backend side to not have additional load of api calls on them, passing xfilters lead to lot of new api requests as cache can't be used. Also, there were UX issues due to the increasing number of api calls. Due to this, we refactored existing components to only have offline filtering and following the same in new features to maintain consistency, this was done a few days ago. cc @venkymano-akamai |
||
| .sort((a, b) => a.label.localeCompare(b.label)); | ||
| }; | ||
Uh oh!
There was an error while loading. Please reload this page.