Skip to content

fix: [UIE-9555] - IAM: clone Volume permission fix #13065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpolotsk-akamai merged 2 commits into from
Nov 12, 2025
Merged

fix: [UIE-9555] - IAM: clone Volume permission fix #13065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c04142
fix: [UIE-9555] - IAM: clone Volume permission fix
mpolotsk-akamai Nov 6, 2025
1511884
Added changeset: IAM: incorrect permission check disabled Clone Volum…
mpolotsk-akamai Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-13065-fixed-1762443312308.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

IAM: incorrect permission check disabled Clone Volume for volume_admin role ([#13065](https://github.com/linode/manager/pull/13065))
1 change: 0 additions & 1 deletion packages/manager/src/features/Volumes/Partials/VolumesActionMenu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ describe('Volume action menu', () => {
queryMocks.usePermissions.mockReturnValue({
update_volume: true,
attach_volume: true,
create_volume: true,
delete_volume: true,
resize_volume: true,
clone_volume: true,
Expand Down
19 changes: 8 additions & 11 deletions packages/manager/src/features/Volumes/Partials/VolumesActionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ export const VolumesActionMenu = (props: Props) => {
const isAttached = volume.linode_id !== null;

const { data: accountPermissions } = usePermissions('account', [
'create_volume',
'is_account_admin',
]);
const { data: volumePermissions, isLoading } = usePermissions(
Expand Down Expand Up @@ -97,18 +96,16 @@ export const VolumesActionMenu = (props: Props) => {
: undefined,
},
CLONE: {
disabled:
!volumePermissions?.clone_volume || !accountPermissions?.create_volume,
disabled: !volumePermissions?.clone_volume,
onClick: handlers.handleClone,
title: 'Clone',
tooltip:
!volumePermissions?.clone_volume || !accountPermissions?.create_volume
? getRestrictedResourceText({
action: 'clone',
isSingular: true,
resourceType: 'Volumes',
})
: undefined,
tooltip: !volumePermissions?.clone_volume
? getRestrictedResourceText({
action: 'clone',
isSingular: true,
resourceType: 'Volumes',
})
: undefined,
},
ATTACH: {
disabled: !volumePermissions?.attach_volume,
Expand Down
11 changes: 3 additions & 8 deletions packages/manager/src/features/Volumes/VolumeDrawers/CloneVolumeDrawer/CloneVolumeDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,11 @@ const initialValues = { label: '' };
export const CloneVolumeDrawer = (props: Props) => {
const { isFetching, onClose: _onClose, open, volume, volumeError } = props;

const { data: accountPermissions } = usePermissions('account', [
'create_volume',
]);
const { data: volumePermissions } = usePermissions(
'volume',
['clone_volume'],
volume?.id
);
const canCloneVolume =
volumePermissions?.clone_volume && accountPermissions?.create_volume;

const { mutateAsync: cloneVolume } = useCloneVolumeMutation();

Expand Down Expand Up @@ -104,7 +99,7 @@ export const CloneVolumeDrawer = (props: Props) => {
title="Clone Volume"
>
<form onSubmit={handleSubmit}>
{!canCloneVolume && (
{!volumePermissions?.clone_volume && (
<Notice
spacingBottom={12}
text="You don't have permission to clone this volume."
Expand All @@ -118,7 +113,7 @@ export const CloneVolumeDrawer = (props: Props) => {
be available in {volume?.region}.
</Typography>
<TextField
disabled={!canCloneVolume}
disabled={!volumePermissions?.clone_volume}
errorText={touched.label ? errors.label : undefined}
label="Label"
name="label"
Expand Down Expand Up @@ -149,7 +144,7 @@ export const CloneVolumeDrawer = (props: Props) => {
/>
<ActionsPanel
primaryButtonProps={{
disabled: !canCloneVolume || isInvalidPrice,
disabled: !volumePermissions?.clone_volume || isInvalidPrice,
label: 'Clone Volume',
loading: isSubmitting,
tooltipText:
Expand Down