upcoming: [UIE-9669] - Implement mocks and factories for Network LoadBalancer - #13104
Merged
harsh-akamai merged 5 commits intoNov 19, 2025
Merged
Conversation
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||
tanushree-akamai
approved these changes
Nov 19, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds mock server handlers and factory functions for the new Network LoadBalancer (NLB) feature, enabling local development and testing without requiring actual API calls.
Key Changes:
- Added three factory functions for NetworkLoadBalancer, NetworkLoadBalancerListener, and NetworkLoadBalancerNode entities
- Implemented five GET endpoint handlers for NLB resources in the mock server
- Updated account factory to include 'Network LoadBalancer' capability
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/manager/src/factories/networkLoadBalancer.ts | New file defining three factory functions for generating mock NLB data structures |
| packages/manager/src/factories/index.ts | Export statement for new networkLoadBalancer factory module |
| packages/manager/src/mocks/serverHandlers.ts | Five new mock handlers for NLB GET endpoints and integration into main handlers array |
| packages/manager/src/factories/account.ts | Added 'Network LoadBalancer' to account capabilities list |
| packages/manager/.changeset/pr-13104-upcoming-features-1763472761959.md | Changeset documenting the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,42 @@ | |||
| import { | |||
Contributor
There was a problem hiding this comment.
Nit: This eslint error is still valid. Let's import type here.
grevanak-akamai
approved these changes
Nov 19, 2025
grevanak-akamai
left a comment
grevanak-akamai
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me
…akamai/manager into uie-9669-add-mocks-to-nlb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add mocks and factories for NLB
Note
Since Network LoadBalancer is only going to support
GETAPI requests, I've added mocks to the legacy server handlers and not CRUD handlersScope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅