change: [UIE-9698] - Add Chip Support to Drawer Component Title - #13135
Merged
harsh-akamai merged 5 commits intoDec 2, 2025
Merged
Conversation
harsh-akamai
marked this pull request as ready for review
November 26, 2025 10:38
harsh-akamai
requested review from
shagufa-akamai
and removed request for
a team
November 26, 2025 10:38
pmakode-akamai
changed the title
pmakode-akamai
approved these changes
Nov 28, 2025
Contributor
There was a problem hiding this comment.
thanks @harsh-akamai! I left a couple of comments that needs to be addressed. I wasn't able to verify the Storybook due to some build errors (which don't seem related to this PR), but the code itself looks good. Also, the PR description and details appear to be outdated - could those be updated?
Approved pending resolution of the comments
| /** | ||
| * Adds a suffix element to the drawer. | ||
| * | ||
| * If set, the drawer will feature a suffix element in the title. |
Contributor
There was a problem hiding this comment.
Suggested change
| * If set, the drawer will feature a suffix element in the title. | |
| * Can be used to indicate special states, such as `BetaChip`, `NewFeatureChip`, or other UI elements next to the title. |
I think it would be better to document this optional prop to make its usage clearer.
| > | ||
| {lastTitleRef.current} | ||
| </Typography> | ||
| <Box display="flex"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <Box display="flex"> | |
| <Box alignItems="center" display="flex"> |
The chip doesn't appear vertically aligned with the title. I think adding alignItems="center" to the Box should fix the alignment
Cloud Manager UI test results🎉 862 passing tests on test run #4 ↗︎
|
bnussman-akamai
approved these changes
Dec 1, 2025
pmakode-akamai
added
Approved
Contributor
|
@harsh-akamai it looks like the changeset is missing - let's add one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add optional title Suffix to the Drawer Title
Changes 🔄
titleSuffixprop to<Drawer/>componenttitleSuffixrenders the component in the Drawer titleScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
titleSuffixprop<BetaChip/>totitleSuffixHow to test 🧪
Verification steps
(How to verify changes)
titleSuffixprop in one of the existing drawersDrawerstorybook additionAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅