Skip to content

upcoming: [UIE-9640] – Update useIsFirewallRulesetsPrefixlistsEnabled to include account capability check - #13156

Merged
dwiley-akamai merged 5 commits into
linode:developfrom
dwiley-akamai:UIE-9640-fw-rulesets-capability-check
Dec 5, 2025
Merged

upcoming: [UIE-9640] – Update useIsFirewallRulesetsPrefixlistsEnabled to include account capability check#13156
dwiley-akamai merged 5 commits into
linode:developfrom
dwiley-akamai:UIE-9640-fw-rulesets-capability-check

Conversation

@dwiley-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Update useIsFirewallRulesetsPrefixlistsEnabled to include account capability check

Changes 🔄

  • Add Cloud Firewall Rule Set to AccountCapability type
  • Update useIsFirewallRulesetsPrefixlistsEnabled() to include account capability check

Scope 🚢

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

December 2025

How to test 🧪

Prerequisites

  • Firewall RuleSets and Prefix Lists has its enabled and beta flags on
  • Your account has the appropriate tags

Verification steps

  • With either the flags off or your account not having the appropriate tags, FW RuleSet and Prefix List content should not be visible in CM
  • With the flags on and your account having the appropriate tags, FW RuleSet and Prefix List content should be visible in CM
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • [X]TypeScript compilation succeeded without errors
  • Code passes all linting rules

…FirewallRulesetsPrefixlistsEnabled() to check for that capability
@dwiley-akamai dwiley-akamai self-assigned this Dec 2, 2025
@dwiley-akamai dwiley-akamai added the Firewalls Related to Firewalls label Dec 2, 2025
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 19 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
19 Failing843 Passing11 Skipped89m 1s

Details

Failing Tests
SpecTest
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » deletes a disk when Linode Disk Encryption is enabled
create-database.spec.tsCloud Manager Cypress Tests→create a database cluster, mocked data » creates a g6-nanode-1 MySQL v8.x 1-node cluster
create-database.spec.tsCloud Manager Cypress Tests→create a database cluster, mocked data » creates a g6-dedicated-2 MySQL v8.x 2-node cluster
create-database.spec.tsCloud Manager Cypress Tests→create a database cluster, mocked data » creates a g6-dedicated-2 MySQL v5.x 3-node cluster
create-database.spec.tsCloud Manager Cypress Tests→create a database cluster, mocked data » creates a g6-nanode-1 PostgreSQL v13.x 3-node cluster
create-database.spec.tsCloud Manager Cypress Tests→create a database cluster, mocked data » creates a g7-premium-4 MySQL v8.x 2-node cluster
upgrade-volume.spec.tsCloud Manager Cypress Tests→volume upgrade/migration » can upgrade an unattached volume to NVMe
upgrade-volume.spec.tsCloud Manager Cypress Tests→volume upgrade/migration » can upgrade an attached volume from the volumes landing page
upgrade-volume.spec.tsCloud Manager Cypress Tests→volume upgrade/migration » can upgrade an attached volume from the linode details page
resize-linode.spec.tsCloud Manager Cypress Tests→resize linode » resizes a linode by increasing size: warm migration
resize-linode.spec.tsCloud Manager Cypress Tests→resize linode » resizes a linode by decreasing size
linode-config.spec.tsCloud Manager Cypress Tests→Linode Config management→End-to-End » Clones a config
delete-volume.spec.tsCloud Manager Cypress Tests→volume delete flow » deletes a volume
machine-image-upload.spec.tsCloud Manager Cypress Tests→machine image » uploads machine image, mock upload canceled failed event
machine-image-upload.spec.tsCloud Manager Cypress Tests→machine image » uploads machine image, mock failed to decompress failed event
machine-image-upload.spec.tsCloud Manager Cypress Tests→machine image » uploads machine image, mock expired upload event
smoke-create-image.spec.tsCloud Manager Cypress Tests→create image (using mocks) » create image from a linode
attach-volume.spec.tsCloud Manager Cypress Tests→volume attach and detach flows » attaches a volume to a Linode
migrate-linode-with-firewall.spec.tsCloud Manager Cypress Tests→Migrate Linode With Firewall » migrates linode with firewall - real data

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/databases/create-database.spec.ts,cypress/e2e/core/volumes/upgrade-volume.spec.ts,cypress/e2e/core/linodes/resize-linode.spec.ts,cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/volumes/delete-volume.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/smoke-create-image.spec.ts,cypress/e2e/core/volumes/attach-volume.spec.ts,cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts"

@dwiley-akamai
dwiley-akamai marked this pull request as ready for review December 4, 2025 14:11
@dwiley-akamai
dwiley-akamai requested a review from a team as a code owner December 4, 2025 14:11

@pmakode-akamai pmakode-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

It's un-related, but the only concern I have is the rulesets will not appear in the /rulesets API, but the references are still showing up in the firewalls/:id API when customer tag is removed. I feel that these references should not appear in the API at all. This is something the API team may need to fix, but I'm not sure.

Details

Image

@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 5, 2025
@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Dec 5, 2025
@grevanak-akamai grevanak-akamai removed the Add'tl Approval Needed Waiting on another approval! label Dec 5, 2025
@pmakode-akamai pmakode-akamai added Approved Multiple approvals and ready to merge! Merge Conflicts labels Dec 5, 2025
@dwiley-akamai

dwiley-akamai commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

Changes look good!

It's un-related, but the only concern I have is the rulesets will not appear in the /rulesets API, but the references are still showing up in the firewalls/:id API when customer tag is removed. I feel that these references should not appear in the API at all. This is something the API team may need to fix, but I'm not sure.

@pmakode-akamai Yes, that's something that should be addressed at the API level I believe. It could pose issues for other consumers of the API too (Terraform, etc.).

@dwiley-akamai

Copy link
Copy Markdown
Contributor Author

The E2E failures all look to be related to the pipeline issues rather than any PR changes, so I'm going ahead and merging.

@dwiley-akamai
dwiley-akamai merged commit e893249 into linode:develop Dec 5, 2025
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Dec 5, 2025
@dwiley-akamai
dwiley-akamai deleted the UIE-9640-fw-rulesets-capability-check branch December 5, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Firewalls Related to Firewalls

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants