Skip to content

fix: [UIE-9891] - Fix logic to remove linode interface from firewall's device page - #13238

Merged
grevanak-akamai merged 2 commits into
linode:developfrom
grevanak-akamai:feature/UIE-9891-update-remove-firewall-for-linode-interface
Jan 5, 2026
Merged

fix: [UIE-9891] - Fix logic to remove linode interface from firewall's device page#13238
grevanak-akamai merged 2 commits into
linode:developfrom
grevanak-akamai:feature/UIE-9891-update-remove-firewall-for-linode-interface

Conversation

@grevanak-akamai

@grevanak-akamai grevanak-akamai commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

Description 📝

As part of this PR, logic to remove devices from a firewall is updated to allow removal of linode interface from it.

Changes 🔄

  • In FirewallDeviceTable.tsx file, logic to derive isLinodeUpdatable is fixed for removal linode interfaces as well.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

NA

Preview 📷

Before After
Screenshot 2026-01-02 at 12 40 47 PM Screenshot 2026-01-02 at 12 40 11 PM

How to test 🧪

Prerequisites

  • Ensure linode interfaces feature is enabled
  • Go to firewalls/{firewall_id}/linodes page

Reproduction steps

  • Currently in prod and test environments, under linodes tab in devices table of firewall details page, Remove button is disabled for linode interfaces.

Verification steps

  • Ensure remove button is enabled for linode interfaces as well
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 870 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing870 Passing11 Skipped47m 19s

@coliu-akamai coliu-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed linode interface device table works as expected for linodes with read/write access (for Linodes where I only have read access, no linode interface features show up, but that's unrelated - iirc it's a known issue due to how the feature flag/account endpoint works for restricted accounts)

thanks @grevanak-akamai!

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Jan 5, 2026
@grevanak-akamai
grevanak-akamai merged commit 5513dbd into linode:develop Jan 5, 2026
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Jan 5, 2026
@grevanak-akamai
grevanak-akamai deleted the feature/UIE-9891-update-remove-firewall-for-linode-interface branch April 22, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Add'tl Approval Needed Waiting on another approval! Firewalls Related to Firewalls Linode Interfaces

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants