Skip to content

upcoming: [DPS-36578] - Custom HTTPS form - additional validation - #13392

Merged
mduda-akamai merged 2 commits into
linode:developfrom
mduda-akamai:feature/DPS-36578-custom-https-form-additional-validation
Mar 4, 2026
Merged

upcoming: [DPS-36578] - Custom HTTPS form - additional validation#13392
mduda-akamai merged 2 commits into
linode:developfrom
mduda-akamai:feature/DPS-36578-custom-https-form-additional-validation

Conversation

@mduda-akamai

@mduda-akamai mduda-akamai commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

Description 📝

Add validation for Endpoint URL and Custom Header Name fields in the Create Destination form

Changes 🔄

  • Endpoint URL: must be a valid URL
  • Custom Header Name forbidden values: Content-Type, Encoding, Authorization, Host, Akamai
  • TLS Hostname: is not required when other certificate details fields are filled

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • Some customers (e.g. in Beta or Limited Availability)

Target release date 🗓️

March 2026

How to test 🧪

Prerequisites

  • Set aclpLogs.customHttpsEnabled and aclpLogs.enabled flags to true

Verification steps

  • In logs/delivery/streams/create or logs/delivery/destinations/create choose Custom HTTPS destination
  • Check if Endpoint URL and custom header's Name fields have proper validation
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mduda-akamai mduda-akamai self-assigned this Feb 12, 2026
@mduda-akamai
mduda-akamai force-pushed the feature/DPS-36578-custom-https-form-additional-validation branch from 6741bc8 to 4f9a939 Compare February 12, 2026 12:13
@mduda-akamai
mduda-akamai marked this pull request as ready for review February 12, 2026 12:13
@mduda-akamai
mduda-akamai requested a review from a team as a code owner February 12, 2026 12:13
@mduda-akamai
mduda-akamai marked this pull request as draft February 12, 2026 13:15
@mduda-akamai
mduda-akamai marked this pull request as draft February 12, 2026 13:15
kagora-akamai
kagora-akamai approved these changes Feb 13, 2026
@kagora-akamai
kagora-akamai self-requested a review February 13, 2026 15:45
@mduda-akamai
mduda-akamai force-pushed the feature/DPS-36578-custom-https-form-additional-validation branch from 4f9a939 to 2d0d4cf Compare February 19, 2026 12:57
@mduda-akamai
mduda-akamai marked this pull request as ready for review February 19, 2026 13:03

@kagora-akamai kagora-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review ✅

@mduda-akamai mduda-akamai added the Add'tl Approval Needed Waiting on another approval! label Feb 19, 2026
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing867 Passing11 Skipped35m 27s

Details

Failing Tests
SpecTest
firewall-landing-page.spec.tsCloud Manager Cypress Tests→confirms Firewalls landing page empty state is shown when no Firewalls exist » lists all Firewalls

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/firewalls/firewall-landing-page.spec.ts"

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Mar 3, 2026
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 3, 2026
@mduda-akamai
mduda-akamai merged commit 5d25e6e into linode:develop Mar 4, 2026
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Logs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants