Skip to content

fix: [UIE-10285] - Advanced Config field tooltip error #13465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hana-akamai merged 2 commits into from
Mar 17, 2026
Merged

fix: [UIE-10285] - Advanced Config field tooltip error #13465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79e9072
set step to any and let validation handle decimals
hana-akamai Mar 4, 2026
05ded53
Added changeset: Database Advanced Config field tooltip error
hana-akamai Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-13465-fixed-1772658612856.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

Database Advanced Config field tooltip error ([#13465](https://github.com/linode/manager/pull/13465))
5 changes: 5 additions & 0 deletions ...ures/Databases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseConfigurationItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,11 @@ export const DatabaseConfigurationItem = (props: Props) => {
placeholder={
configItem.isNew ? String(configItem?.example ?? '') : ''
}
slotProps={{
htmlInput: {
step: 'any', // UIE-10285: Fix edge-case tooltip

@hana-akamai hana-akamai Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow any value and let user agent round to the nearest value https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/number#step

@smans-akamai smans-akamai Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does every numeric field for advanced configuration not accept floats? If so, then would this cause it to round behind the scenes every time or only in certain cases? As an alternative, would it make sense to provide an inline error when floats are provided to the input like we do with some of the other validation?

Since this would apply the change to all the number and integer fields in the config response I was curious about the behavior.

@smans-akamai smans-akamai Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it does throw this type of validation error when I reduce the value for group_concat_max_len to 900719925474099.6 so maybe this is an issue with the size of the number and the validation?

Screenshot 2026-03-05 at 4 42 25 PM

From the schema, it looks like the integer fields are set up to throw validation errors for floats while Number fields won't. Would this rounding behavior only get applied to the integer fields?

@smans-akamai smans-akamai Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any number config fields for MySQL clusters, so I tested this with one in PostgreSQL.
I used shared_buffers_percentage that has the highest max value I could find at 60 and decimal values were being provided as expected. I'm not sure why the integer validation isn't being applied in the original case, but this doesn't seem to effect the behavior for number fields

Screenshot 2026-03-05 at 5 11 21 PM

@hana-akamai hana-akamai Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smans-akamai seems like the integer validation isn't being applied in the original case because 9007199254740991 is the maximum safe integer value in JavaScript. So very large values are throwing the validation off. Don't think there's anything we can really do about that

@smans-akamai smans-akamai Mar 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see! This sounds like a limitation issue then. I'm not sure how we can address this, but the updated rounding behavior does seem to prevent the tooltip error for the issue.

},
}}
type="number"
value={configItem.value}
/>
Expand Down