Skip to content

upcoming: [UIE-9376] — Add Image select table to Linode Rebuild dialog - #13482

Merged
dwiley-akamai merged 7 commits into
linode:developfrom
dwiley-akamai:UIE-9376-img-selection-table-rebuild-dialog
Mar 18, 2026
Merged

upcoming: [UIE-9376] — Add Image select table to Linode Rebuild dialog#13482
dwiley-akamai merged 7 commits into
linode:developfrom
dwiley-akamai:UIE-9376-img-selection-table-rebuild-dialog

Conversation

@dwiley-akamai

@dwiley-akamai dwiley-akamai commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Description 📝

Add Image select table to Linode Rebuild dialog

Changes 🔄

  • Use ImageSelectTable instead of Image Select dropdown in Linode Rebuild dialog when the Private Image Sharing feature flag is on
  • Add Pendo IDs for the ImageSelectTable instance in the Rebuild dialog (and rename the constant for the Pendo IDs used in the Linode Create flow)

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

TBD

Preview 📷

Before After
Screenshot 2026-03-12 at 5 22 00 PM Screenshot 2026-03-12 at 5 22 52 PM

How to test 🧪

Prerequisites

Toggle the Private Image Sharing flag in the CM DevTool

Verification steps

With the Private Image Sharing flag on...

  • From (1) the Linodes landing page and (2) a Linode Details page, open the Rebuild dialog for a linode via the three-dot menu. The dialog should have the new image select table rather than the image select dropdown
  • The image select table should function as expected (pagination, searching/filtering, hovering over the "Replicated in" cells, etc.)

With the Private Image Sharing flag off...

  • The Rebuild dialog should still have the current image select dropdown with no other UI changes visible.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@dwiley-akamai dwiley-akamai self-assigned this Mar 11, 2026
@dwiley-akamai dwiley-akamai added the Private Image Sharing Related to Private Image Sharing feature label Mar 11, 2026
Comment on lines 90 to 92
const [query, setQuery] = useState('');
const [selectedTag, setSelectedTag] = useState<null | string>(null);
const [selectedRegion, setSelectedRegion] = useState<null | string>(null);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on #13435 (comment), I think the Rebuild dialog being accessible from the Linodes landing page makes things a bit more complex 🤔 in the interest of keeping the feature work rolling, we can perhaps circle back to that as an enhancement

@dwiley-akamai
dwiley-akamai marked this pull request as ready for review March 12, 2026 22:08
@dwiley-akamai
dwiley-akamai requested a review from a team as a code owner March 12, 2026 22:08

@fabrice-akamai fabrice-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dwiley-akamai 👍!

@abailly-akamai abailly-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending small path matching swap

Comment thread packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/Image.tsx Outdated
@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Mar 17, 2026
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 4 failing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing876 Passing11 Skipped45m 58s

Details

Failing Tests
SpecTest
object-storage-objects-multicluster.spec.tsCloud Manager Cypress Tests→Object Storage Multicluster objects » can upload, access, and delete objects
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets
rebuild-linode.spec.tsCloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Account StackScript
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with LKE-E→shows the LKE-E flow with the feature flag on » creates an LKE-E cluster with the account capability

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/linodes/rebuild-linode.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts"

@dwiley-akamai

Copy link
Copy Markdown
Contributor Author

rebuild-linode.spec.ts failed in the last CI run but I ran it locally on this branch to confirm it wasn't a legitimate failure. Proceeding with merging

Screenshot 2026-03-18 at 10 43 21 AM

@dwiley-akamai
dwiley-akamai merged commit f18fce5 into linode:develop Mar 18, 2026
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Mar 18, 2026
@dwiley-akamai
dwiley-akamai deleted the UIE-9376-img-selection-table-rebuild-dialog branch March 18, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Private Image Sharing Related to Private Image Sharing feature

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants