fix: [UIE-10472] - Remove unintended validation on optional email fields in Contact Sales Drawer - #13483
Merged
harsh-akamai merged 8 commits intoMar 18, 2026
Conversation
…lds in Contact Sales Drawer
…tps://github.com/harsh-akamai/manager into uie-10472-fix-email-validation-for-contact-sales
Contributor
|
Need changeset for this fix. |
grevanak-akamai
approved these changes
Mar 16, 2026
grevanak-akamai
left a comment
grevanak-akamai
left a comment
Contributor
There was a problem hiding this comment.
Verified all the use cases and confirm that form validation works as expected now. Thanks @harsh-akamai
harsh-akamai
requested review from
pmakode-akamai,
tanushree-akamai and
tvijay-akamai
March 17, 2026 06:31
harsh-akamai
requested review from
shagufa-akamai
and removed request for
a team
March 17, 2026 14:02
harsh-akamai
force-pushed
the
uie-10472-fix-email-validation-for-contact-sales
branch
2 times, most recently
from
March 17, 2026 14:25
8290eb9 to
2025b32
Compare
harsh-akamai
requested review from
jdamore-linode
and removed request for
a team
March 17, 2026 14:25
harsh-akamai
force-pushed
the
uie-10472-fix-email-validation-for-contact-sales
branch
from
March 17, 2026 14:28
2025b32 to
8290eb9
Compare
| const cleanedAdditionalEmails = values.additional_emails?.filter((e) => | ||
| e?.trim() | ||
| ); | ||
| const cleanUpPayload = (values: MarketplacePartnerReferralPayload) => { |
Contributor
There was a problem hiding this comment.
I would recommend to add unit tests and comments for cleanUpPayload.
Cloud Manager UI test results🔺 4 failing tests on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/images/search-images.spec.ts,cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts" |
||||||||||||||||||||||||||
harsh-akamai
force-pushed
the
uie-10472-fix-email-validation-for-contact-sales
branch
2 times, most recently
from
March 18, 2026 02:54
9530390 to
4680800
Compare
…10472-fix-email-validation-for-contact-sales
…s in Contact Sales Drawer
tanushree-akamai
approved these changes
Mar 18, 2026
tanushree-akamai
left a comment
tanushree-akamai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @harsh-akamai! Do verify if the failing tests are due to the PR before merging.
This was referenced Mar 25, 2026
grevanak-akamai
pushed a commit
that referenced
this pull request
Apr 23, 2026
…lds in Contact Sales Drawer (#13483) * fix: [UIE-10472] - Remove unintended validation on optional email fields in Contact Sales Drawer * trigger validation for additional email field * fix failing test * Added changeset: Remove unintended validation on optional email fields in Contact Sales Drawer * Added unit tests and comments for the clean up function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
When a user enters then clears a value in the additional email field of the Contact Sales drawer, a validation error is incorrectly thrown. Similarly, clearing a value in the Akamai executive email field causes it to be treated as a required field.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-03-11.at.6.23.07.PM.mov
Screen.Recording.2026-03-11.at.6.16.00.PM.mov
How to test 🧪
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅