Skip to content

upcoming: [DPS-41183] - Migrate content to details for Notification Channels - #13495

Merged
santoshp210-akamai merged 4 commits into
linode:developfrom
santoshp210-akamai:feature/notification-channel-use-details-field
Mar 17, 2026
Merged

upcoming: [DPS-41183] - Migrate content to details for Notification Channels#13495
santoshp210-akamai merged 4 commits into
linode:developfrom
santoshp210-akamai:feature/notification-channel-use-details-field

Conversation

@santoshp210-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Migrate the usage from content to details for Notification Channels

Changes 🔄

List any change(s) relevant to the reviewer.

  • replace content with details
  • return recipient_type if usernames are empty and recipient_type is not user
  • remove content in UTs, mocks, cypress tests

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

28th March

Preview 📷

No UI changes

How to test 🧪

Prerequisites

(How to setup test environment)

  • In any environment, just go through the flows of ACLP-alerts and NotificationChannels

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

(How to verify changes)

  • Verify that there is no change in UI before and now
  • Verify that dependency on content has been removed
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@santoshp210-akamai
santoshp210-akamai requested a review from a team as a code owner March 13, 2026 15:22
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 3 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing877 Passing11 Skipped41m 45s

Details

Failing Tests
SpecTest
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with LKE-E→shows the LKE-E flow with the feature flag on » creates an LKE-E cluster with the account capability
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets
object-storage-objects-multicluster.spec.tsCloud Manager Cypress Tests→Object Storage Multicluster objects » can upload, access, and delete objects

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts"

@kmuddapo kmuddapo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Mar 16, 2026
@santoshp210-akamai

Copy link
Copy Markdown
Contributor Author

Merging this as the failing cypress tests are not related.

@santoshp210-akamai
santoshp210-akamai merged commit cac8d8c into linode:develop Mar 17, 2026
34 of 35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Mar 17, 2026
grevanak-akamai pushed a commit that referenced this pull request Apr 23, 2026
…hannels (#13495)

* upcoming: [DPS-41183] - Migrate content to details for Notification Channels

* add changesets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants